LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: travis@sgi.com To: Andrew Morton <akpm@linux-foundation.org>, Andi Kleen <ak@suse.de>, mingo@elte.hu Cc: Christoph Lameter <clameter@sgi.com>, Jack Steiner <steiner@sgi.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/10] x86: Change NR_CPUS arrays in numa_64 Date: Sun, 13 Jan 2008 10:35:01 -0800 [thread overview] Message-ID: <20080113183455.077460000@sgi.com> (raw) In-Reply-To: 20080113183453.973425000@sgi.com [-- Attachment #1: NR_CPUS-arrays-in-numa_64 --] [-- Type: text/plain, Size: 4714 bytes --] Change the following static arrays sized by NR_CPUS to per_cpu data variables: char cpu_to_node_map[NR_CPUS]; Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/setup_64.c | 4 +++- arch/x86/kernel/smpboot_64.c | 6 +++++- arch/x86/mm/numa_64.c | 20 ++++++++++++++++---- include/asm-x86/numa_64.h | 2 -- include/asm-x86/topology.h | 15 +++++++++++++-- net/sunrpc/svc.c | 1 + 6 files changed, 38 insertions(+), 10 deletions(-) --- a/arch/x86/kernel/setup_64.c +++ b/arch/x86/kernel/setup_64.c @@ -63,6 +63,7 @@ #include <asm/cacheflush.h> #include <asm/mce.h> #include <asm/ds.h> +#include <asm/topology.h> #ifdef CONFIG_PARAVIRT #include <asm/paravirt.h> @@ -372,8 +373,9 @@ void __init setup_arch(char **cmdline_p) io_delay_init(); #ifdef CONFIG_SMP - /* setup to use the static apicid table during kernel startup */ + /* setup to use the early static init tables during kernel startup */ x86_cpu_to_apicid_early_ptr = (void *)&x86_cpu_to_apicid_init; + x86_cpu_to_node_map_early_ptr = (void *)&x86_cpu_to_node_map_init; #endif #ifdef CONFIG_ACPI --- a/arch/x86/kernel/smpboot_64.c +++ b/arch/x86/kernel/smpboot_64.c @@ -861,9 +861,12 @@ void __init smp_set_apicids(void) int cpu; for_each_possible_cpu(cpu) { - if (per_cpu_offset(cpu)) + if (per_cpu_offset(cpu)) { per_cpu(x86_cpu_to_apicid, cpu) = x86_cpu_to_apicid_init[cpu]; + per_cpu(x86_cpu_to_node_map, cpu) = + x86_cpu_to_node_map_init[cpu]; + } else printk(KERN_NOTICE "per_cpu_offset zero for cpu %d\n", cpu); @@ -871,6 +874,7 @@ void __init smp_set_apicids(void) /* indicate the early static arrays are gone */ x86_cpu_to_apicid_early_ptr = NULL; + x86_cpu_to_node_map_early_ptr = NULL; } static void __init smp_cpu_index_default(void) --- a/arch/x86/mm/numa_64.c +++ b/arch/x86/mm/numa_64.c @@ -31,10 +31,14 @@ bootmem_data_t plat_node_bdata[MAX_NUMNO struct memnode memnode; -u16 cpu_to_node_map[NR_CPUS] __read_mostly = { +u16 x86_cpu_to_node_map_init[NR_CPUS] __initdata = { [0 ... NR_CPUS-1] = NUMA_NO_NODE }; -EXPORT_SYMBOL(cpu_to_node_map); +void *x86_cpu_to_node_map_early_ptr; +EXPORT_SYMBOL(x86_cpu_to_node_map_init); +EXPORT_SYMBOL(x86_cpu_to_node_map_early_ptr); +DEFINE_PER_CPU(u16, x86_cpu_to_node_map) = NUMA_NO_NODE; +EXPORT_PER_CPU_SYMBOL(x86_cpu_to_node_map); u16 apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE @@ -545,7 +549,7 @@ void __init numa_initmem_init(unsigned l node_set(0, node_possible_map); for (i = 0; i < NR_CPUS; i++) numa_set_node(i, 0); - /* we can't use cpumask_of_cpu() yet */ + /* cpumask_of_cpu() may not be available during early startup */ memset(&node_to_cpumask_map[0], 0, sizeof(node_to_cpumask_map[0])); cpu_set(0, node_to_cpumask_map[0]); e820_register_active_regions(0, start_pfn, end_pfn); @@ -559,8 +563,16 @@ __cpuinit void numa_add_cpu(int cpu) void __cpuinit numa_set_node(int cpu, int node) { + u16 *cpu_to_node_map = (u16 *)x86_cpu_to_node_map_early_ptr; + cpu_pda(cpu)->nodenumber = node; - cpu_to_node_map[cpu] = node; + + if(cpu_to_node_map) + cpu_to_node_map[cpu] = node; + else if(per_cpu_offset(cpu)) + per_cpu(x86_cpu_to_node_map, cpu) = node; + else + Dprintk(KERN_INFO "Setting node for non-present cpu %d\n", cpu); } unsigned long __init numa_free_all_bootmem(void) --- a/include/asm-x86/numa_64.h +++ b/include/asm-x86/numa_64.h @@ -40,6 +40,4 @@ static inline void clear_node_cpumask(in #define clear_node_cpumask(cpu) do {} while (0) #endif -#define NUMA_NO_NODE 0xffff - #endif --- a/include/asm-x86/topology.h +++ b/include/asm-x86/topology.h @@ -30,13 +30,24 @@ #include <asm/mpspec.h> /* Mappings between logical cpu number and node number */ -extern u16 cpu_to_node_map[]; +DECLARE_PER_CPU(u16, x86_cpu_to_node_map); +extern u16 __initdata x86_cpu_to_node_map_init[]; +extern void *x86_cpu_to_node_map_early_ptr; extern cpumask_t node_to_cpumask_map[]; +#define NUMA_NO_NODE ((u16)(~0)) + /* Returns the number of the node containing CPU 'cpu' */ static inline int cpu_to_node(int cpu) { - return cpu_to_node_map[cpu]; + u16 *cpu_to_node_map = (u16 *)x86_cpu_to_node_map_early_ptr; + + if (cpu_to_node_map) + return cpu_to_node_map[cpu]; + else if(per_cpu_offset(cpu)) + return per_cpu(x86_cpu_to_node_map, cpu); + else + return NUMA_NO_NODE; } /* --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -18,6 +18,7 @@ #include <linux/mm.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/sched.h> #include <linux/sunrpc/types.h> #include <linux/sunrpc/xdr.h> --
next prev parent reply other threads:[~2008-01-13 18:35 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-13 18:34 [PATCH 00/10] x86: Reduce memory and intra-node effects with large count NR_CPUs travis 2008-01-13 18:34 ` [PATCH 01/10] x86: Change size of APICIDs from u8 to u16 travis 2008-01-14 12:23 ` Mel Gorman 2008-01-14 18:13 ` Mike Travis 2008-01-14 19:26 ` Mike Travis 2008-01-14 18:10 ` Jan Engelhardt 2008-01-14 18:22 ` Mike Travis 2008-01-14 18:32 ` Mike Travis 2008-01-14 19:16 ` Christoph Lameter 2008-01-13 18:34 ` [PATCH 02/10] x86: Change size of node ids " travis 2008-01-13 20:01 ` Eric Dumazet 2008-01-13 18:34 ` [PATCH 03/10] x86: Change NR_CPUS arrays in powernow-k8 travis 2008-01-13 18:34 ` [PATCH 04/10] x86: Change NR_CPUS arrays in intel_cacheinfo travis 2008-01-13 18:34 ` [PATCH 05/10] x86: Change NR_CPUS arrays in smpboot_64 travis 2008-01-13 18:34 ` [PATCH 06/10] x86: Change NR_CPUS arrays in topology travis 2008-01-14 18:25 ` Jan Engelhardt 2008-01-14 19:08 ` Mike Travis 2008-01-13 18:35 ` [PATCH 07/10] x86: Cleanup x86_cpu_to_apicid references travis 2008-01-13 18:35 ` travis [this message] 2008-01-14 11:14 ` [PATCH 08/10] x86: Change NR_CPUS arrays in numa_64 Ingo Molnar 2008-01-14 17:17 ` Mike Travis 2008-01-14 18:14 ` Jan Engelhardt 2008-01-13 18:35 ` [PATCH 09/10] x86: Change NR_CPUS arrays in acpi-cpufreq travis 2008-01-13 18:35 ` [PATCH 10/10] x86: Change bios_cpu_apicid to percpu data variable travis 2008-01-14 8:14 ` [PATCH 00/10] x86: Reduce memory and intra-node effects with large count NR_CPUs Ingo Molnar 2008-01-14 9:00 ` Ingo Molnar 2008-01-14 17:52 ` Mike Travis 2008-01-14 10:04 ` Andi Kleen 2008-01-14 10:11 ` Ingo Molnar 2008-01-14 11:30 ` Andi Kleen 2008-01-16 7:34 ` Nick Piggin 2008-01-16 18:07 ` Christoph Lameter 2008-01-14 18:00 ` Mike Travis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080113183455.077460000@sgi.com \ --to=travis@sgi.com \ --cc=ak@suse.de \ --cc=akpm@linux-foundation.org \ --cc=clameter@sgi.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@elte.hu \ --cc=steiner@sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).