LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, but takes just 1
Date: Sun, 13 Jan 2008 20:53:21 +0100 [thread overview]
Message-ID: <200801132053.22830.m.kozlowski@tuxland.pl> (raw)
In-Reply-To: <1200250801.9190.7.camel@localhost.localdomain>
Hello,
> We are pleased to announce the 2.6.24-rc7-rt1 tree, which can be
> downloaded from the location:
>
> http://rt.et.redhat.com/download/
CC arch/x86/mm/init_32.o
In file included from include/asm-generic/tlb.h:17,
from include/asm/tlb.h:9,
from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h:73:28: error: macro "put_cpu_var" passed 2 arguments, but takes just 1
In file included from include/asm-generic/tlb.h:17,
from include/asm/tlb.h:9,
from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h: In function '__quicklist_free':
include/linux/quicklist.h:73: error: 'put_cpu_var' undeclared (first use in this function)
include/linux/quicklist.h:73: error: (Each undeclared identifier is reported only once
include/linux/quicklist.h:73: error: for each function it appears in.)
make[1]: *** [arch/x86/mm/init_32.o] Error 1
make: *** [arch/x86/mm] Error 2
--- linux-2.6.24-rc7-rt1.orig/include/linux/quicklist.h 2008-01-11 21:16:22.000000000 -0500
+++ linux-2.6.24-rc7-rt1/include/linux/quicklist.h 2008-01-11 21:18:08.000000000 -0500
@@ -18,7 +18,7 @@ struct quicklist {
int nr_pages;
};
[... snip ...]
@@ -56,12 +64,13 @@ static inline void __quicklist_free(int
struct page *page)
{
struct quicklist *q;
+ int cpu;
- q = &get_cpu_var(quicklist)[nr];
+ q = &get_cpu_var_locked(quicklist, &cpu)[nr];
*(void **)p = q->page;
q->page = p;
q->nr_pages++;
- put_cpu_var(quicklist);
+ put_cpu_var(quicklist, cpu); <------------- should that be put_cpu_var_locked()?
}
Regards,
Mariusz
next prev parent reply other threads:[~2008-01-13 19:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 19:00 2.6.24-rc7-rt1 Steven Rostedt
2008-01-13 19:53 ` Mariusz Kozlowski [this message]
2008-01-13 20:37 ` 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, but takes just 1 Steven Rostedt
2008-01-13 20:25 ` 2.6.24-rc7-rt1 Robert Schwebel
2008-01-13 20:48 ` 2.6.24-rc7-rt1 Steven Rostedt
2008-01-14 19:49 ` 2.6.24-rc7-rt1 Robert Schwebel
2008-01-13 20:43 ` 2.6.24-rc7-rt1 Mariusz Kozlowski
2008-01-13 20:54 ` 2.6.24-rc7-rt1 Steven Rostedt
2008-01-14 8:27 ` 2.6.24-rc7-rt1 Mike Galbraith
2008-01-14 12:13 ` 2.6.24-rc7-rt1 Gregory Haskins
2008-01-14 13:25 ` 2.6.24-rc7-rt1 Mike Galbraith
2008-01-14 14:29 ` 2.6.24-rc7-rt1 Mike Galbraith
2008-01-15 8:07 ` 2.6.24-rc7-rt1 Mike Galbraith
2008-01-15 9:28 ` 2.6.24-rc7-rt1 Mike Galbraith
2008-01-15 16:50 ` 2.6.24-rc7-rt1 Gregory Haskins
2008-01-14 18:39 ` 2.6.24-rc7-rt1 S.Çağlar Onur
2008-01-14 16:52 ` 2.6.24-rc7-rt1 Steven Rostedt
2008-01-13 22:56 ` 2.6.24-rc7-rt1 Mark Knecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801132053.22830.m.kozlowski@tuxland.pl \
--to=m.kozlowski@tuxland.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).