checkpatch: add filename before the summary line

checkpatch: add filename before the summary line

[Paolo Ciarrocchi]

With the patch applied the output of checkpatch.pl is as follow:
./arch/arm/mach-footbridge/ebsa285-pci.c 
total: 1 errors, 0 warnings, 48 lines checked

Adding the file name allowed me to collects stats running:
	find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total
but I though it might me useful for other purposes to add the file name
after the list of errors and warnings and before the summary,
when the list is long I find handy to print out the filename as a reminder.
   
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..079c73c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1580,6 +1580,7 @@ sub process {
 
 	print report_dump();
 	if ($summary) {
+		print "$filename \n";
 		print "total: $cnt_error errors, $cnt_warn warnings, " .
 			(($check)? "$cnt_chk checks, " : "") .
 			"$cnt_lines lines checked\n";

Re: checkpatch: add filename before the summary line

[Andy Whitcroft]

On Sun, Jan 13, 2008 at 11:34:05PM +0100, Paolo Ciarrocchi wrote:
> With the patch applied the output of checkpatch.pl is as follow:
> ./arch/arm/mach-footbridge/ebsa285-pci.c 
> total: 1 errors, 0 warnings, 48 lines checked
> 
> Adding the file name allowed me to collects stats running:
> 	find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total
> but I though it might me useful for other purposes to add the file name
> after the list of errors and warnings and before the summary,
> when the list is long I find handy to print out the filename as a reminder.

Hmmm, that being unconfitional would probabally break a raft of other
users.  Also would it be more useful to put it on the front of the
summary line?  So that if you have a bunch of files to check then you
get something more like:

foo: total: 1 errors, ...
bar: total: 0 errors, ...

-apw

Re: checkpatch: add filename before the summary line

[Paolo Ciarrocchi]

On Jan 14, 2008 6:30 PM, Andy Whitcroft <apw@shadowen.org> wrote:
> On Sun, Jan 13, 2008 at 11:34:05PM +0100, Paolo Ciarrocchi wrote:
> > With the patch applied the output of checkpatch.pl is as follow:
> > ./arch/arm/mach-footbridge/ebsa285-pci.c
> > total: 1 errors, 0 warnings, 48 lines checked
> >
> > Adding the file name allowed me to collects stats running:
> >       find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total
> > but I though it might me useful for other purposes to add the file name
> > after the list of errors and warnings and before the summary,
> > when the list is long I find handy to print out the filename as a reminder.
>
> Hmmm, that being unconfitional would probabally break a raft of other
> users.  Also would it be more useful to put it on the front of the
> summary line?  So that if you have a bunch of files to check then you
> get something more like:
>
> foo: total: 1 errors, ...
> bar: total: 0 errors, ...

I have a patch that adds an option (default to false) and with that I have
the following output:

./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked
./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked

Will send to the list in a few minutes.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/