From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbYANAqd (ORCPT ); Sun, 13 Jan 2008 19:46:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751937AbYANAqW (ORCPT ); Sun, 13 Jan 2008 19:46:22 -0500 Received: from cavan.codon.org.uk ([78.32.9.130]:34416 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbYANAqV (ORCPT ); Sun, 13 Jan 2008 19:46:21 -0500 Date: Mon, 14 Jan 2008 00:35:54 +0000 From: Matthew Garrett To: Henrique de Moraes Holschuh Cc: Pavel Machek , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20080114003553.GA1698@srcf.ucam.org> References: <20080112022348.GC27524@khazad-dum.debian.net> <200801120416.08631.lenb@kernel.org> <20080113165801.GA4132@ucw.cz> <20080113234129.GE10693@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080113234129.GE10693@khazad-dum.debian.net> User-Agent: Mutt/1.5.12-2006-07-14 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk Subject: Re: Lenovo ThinkPads need acpi_osi="Linux" X-SA-Exim-Version: 4.2.1 (built Tue, 20 Jun 2006 01:35:45 +0000) X-SA-Exim-Scanned: Yes (on vavatch.codon.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 13, 2008 at 09:41:29PM -0200, Henrique de Moraes Holschuh wrote: > On Sun, 13 Jan 2008, Pavel Machek wrote: > > When linux calls video BIOS with lcall (acpi_sleep=s3_bios), they > > should turn on backlight and put video into text mode. They should > > also make sure mode setting works after that. > > IMHO, in that case, we should probably be whitelist-enabling that on > thinkpads (and allow for acpi_sleep=none to override it), or letting > userspace change it at runtime. No. This breaks on the R50e, at least - I suspect it'd also have problems on any nvidia based machines, but I don't have one to hand at the moment. It can be set at runtime already. -- Matthew Garrett | mjg59@srcf.ucam.org