LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
	stefanr@s5r6.in-berlin.de, James.Bottomley@hansenpartnership.com,
	a.zummo@towertech.it, peterz@infradead.org, cbou@mail.ru,
	linux-kernel@vger.kernel.org,
	David Brownell <david-b@pacbell.net>,
	krh@redhat.com, stern@rowland.harvard.edu, dwmw2@infradead.org,
	davem@davemloft.net
Subject: Re: [PATCH 1/7] driver-core : add class iteration api
Date: Mon, 14 Jan 2008 07:58:21 +0100	[thread overview]
Message-ID: <20080114065821.GA1643@ff.dom.local> (raw)
In-Reply-To: <a8e1da0801131736i4fa2eed7pd1569ed1b6214510@mail.gmail.com>

On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote:
> On Jan 13, 2008 4:11 AM, Jarek Poplawski <jarkao2@gmail.com> wrote:
...
> > Probably some tiny oversight, but I see this comment to struct class
> > doesn't mention devices list, so maybe this needs to be updated BTW?:
> >
> > (from include/linux/device.h)
> > "        struct semaphore        sem;    /* locks both the children and interfaces lists */"
> 
> Sorry for my lazy, I think so too.
> IMHO, it should be updated after the comments.

As a matter of fact, only later I've found this question is 'fixed' in
7/7. But, actually, I was more concerned if this patch changed the
'official' policy of this sem (then it would be nice to mention about
this in a changelog) or this comment was simply incomplete.

Thanks,
Jarek P.

  reply	other threads:[~2008-01-14  6:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-12  9:47 [PATCH 1/7] driver-core : add class iteration api Dave Young
2008-01-12 10:50 ` Stefan Richter
2008-01-14  1:32   ` Dave Young
2008-01-12 20:11 ` Jarek Poplawski
2008-01-14  1:36   ` Dave Young
2008-01-14  6:58     ` Jarek Poplawski [this message]
2008-01-14  7:00       ` Dave Young
2008-01-14 12:13 ` Cornelia Huck
2008-01-15  0:17   ` Dave Young
2008-01-15  9:13 ` Dave Young
2008-01-15  9:45   ` Cornelia Huck
2008-01-22  5:54 ` [PATCH 1/6] " Dave Young
2008-01-22  6:06   ` Dave Young
2008-01-22  6:24   ` David Brownell
2008-01-22  6:30     ` Dave Young
2008-01-22  7:27     ` Dave Young
2008-01-22  8:44       ` Cornelia Huck
2008-01-22 22:25       ` Greg KH
2008-01-23  1:02         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080114065821.GA1643@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=a.zummo@towertech.it \
    --cc=cbou@mail.ru \
    --cc=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=hidave.darkstar@gmail.com \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).