LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marc Pignat <marc.pignat@hevs.ch>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: wim@iguana.be, linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH] watchdog on gpio
Date: Mon, 14 Jan 2008 08:34:53 +0100	[thread overview]
Message-ID: <200801140834.54280.marc.pignat@hevs.ch> (raw)
In-Reply-To: <200801111740.25754.florian.fainelli@telecomint.eu>

On Friday 11 January 2008, Florian Fainelli wrote:
> Hello Marc,
> 
> Your patch looks good to me, and I have been waiting for something like 
> this :). Other comments below.
> 
> Le jeudi 10 janvier 2008, Marc Pignat a écrit :
> > +#include <asm/uaccess.h>
> > +#include <asm/arch/gpio.h>
> 
> At first sight, this will only work with the platforms which have implemented 
> gpiolib, some (like MIPS) still use the old generic GPIO API. So I think the 
> include will not work here for anything than ARM, correct me if I am wrong.
find arch -name "Kconfig" -exec grep -q "GENERIC_GPIO" {} \; -print
arch/arm/Kconfig
arch/mips/Kconfig
arch/avr32/Kconfig
arch/blackfin/Kconfig

It seems that no only arm are using GENERIC_GPIO, even some mips chips.
I probably missed wirting the subject right, should be "watchdog on GENERIC_GPIO" :)

...
> 
> Did you look into hooking into Wim's uniform watchdog driver :
> 
> http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-experimental.git;a=commit;h=732c54027e6c866f98857c4a6d1c6c466459dcd5
Now yes, interesting!

Regards

Marc


  reply	other threads:[~2008-01-14  7:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 15:11 Marc Pignat
2008-01-10 17:14 ` Ben Dooks
2008-01-11 16:40 ` Florian Fainelli
2008-01-14  7:34   ` Marc Pignat [this message]
2008-01-14  8:08   ` Mike Frysinger
2008-01-14  8:04 ` Mike Frysinger
2008-01-14  9:03   ` Alan Cox
2008-01-14  9:28     ` Mike Frysinger
2008-01-14  9:29       ` Alan Cox
2008-01-14  9:45         ` Mike Frysinger
2008-01-14 12:14           ` Haavard Skinnemoen
2008-01-14 12:22             ` Mike Frysinger
2008-01-14 13:30               ` Haavard Skinnemoen
2008-01-14 12:49           ` Johannes Weiner
2008-01-14 13:03             ` Mike Frysinger
2008-01-14 13:56               ` printk-wrapper with sectionized string constants [was: Re: [RFC, PATCH] watchdog on gpio] Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801140834.54280.marc.pignat@hevs.ch \
    --to=marc.pignat@hevs.ch \
    --cc=florian.fainelli@telecomint.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wim@iguana.be \
    --subject='Re: [RFC, PATCH] watchdog on gpio' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).