Re: [PATCH 10/16] udf: create common function for changing free space counter

[Jan Kara <jack@suse.cz>]

On Sat 12-01-08 14:13:31, Marcin Slusarz wrote:
> On Fri, Jan 11, 2008 at 12:24:49AM +0100, Jan Kara wrote:
> > On Thu 10-01-08 23:06:26, marcin.slusarz@gmail.com wrote:
> > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > > CC: Jan Kara <jack@suse.cz>
> > > CC: Christoph Hellwig <hch@infradead.org>
> >   Just two minor comment...
> > 
> > > ---
> > >  fs/udf/balloc.c |   49 ++++++++++++++++++++-----------------------------
> > >  1 files changed, 20 insertions(+), 29 deletions(-)
> > > 
> > > diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
> > > index dc9f8a9..78dbf1d 100644
> > > --- a/fs/udf/balloc.c
> > > +++ b/fs/udf/balloc.c
> > > @@ -140,6 +140,20 @@ static inline int load_block_bitmap(struct super_block *sb,
> > >  	return slot;
> > >  }
> > >  
> > > +static bool udf_inc_free_space(struct udf_sb_info *sbi,
> >   Maybe because you use the function for both increasing and decreasing
> > free space, you could call is udf_add_free_space?
> Ok. Done.
> 
> > 
> > > +				u16 partition, u32 cnt)
> > > +{
> > > +	struct logicalVolIntegrityDesc *lvid;
> > > +
> > > +	if (sbi->s_lvid_bh)
> > > +		return false;
> > > +
> > > +	lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
> > > +	lvid->freeSpaceTable[partition] = cpu_to_le32(le32_to_cpu(
> > > +					lvid->freeSpaceTable[partition]) + cnt);
> >   I think macro like le32_add_cpu() just went into the kernel so you could
> > use that...
> I didn't want to rely on too many patches, so I intentionally left it.
> I'll convert it together with other le*_add_cpu changes.
  OK, fair enough.

> Can you ack this patch with udf_inc_free_space rename?
  Yes.
  Acked-by: Jan Kara <jack@suse.cz>

										Honza

-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR