LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Daniel Walker <dwalker@mvista.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Bernd Petrovitsch <bernd@firmix.at>,
linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] checkpatch.pl: show how to read from stdin
Date: Mon, 14 Jan 2008 19:12:43 +0000 [thread overview]
Message-ID: <20080114191243.GB25058@shadowen.org> (raw)
In-Reply-To: <1200332116.31521.3.camel@imap.mvista.com>
On Mon, Jan 14, 2008 at 09:35:15AM -0800, Daniel Walker wrote:
>
> On Mon, 2008-01-14 at 17:17 +0000, Andy Whitcroft wrote:
> > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote:
> > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> > > Acked-by: Jiri Slaby <jirislaby@gmail.com>
> >
> > As an absolute minimum this seems reasonable to me. I guess we could
> > make no arguments default to '-' also. There are up and downsides to
> > doing that, as currently no arguments currently tell you the usage and
> > with this patch would point clearly out the '-' option. Just assuming
> > stding would lose easy access to usage, which may actually be more
> > confusing for the beginner. Hmmm. Cirtainly will include this
> > documentation change if nothing else.
> >
>
> The patch that I submitted checks STDIN for piped data, and if there is
> any it will default to checking that incoming data .. That's regardless
> of the number of arguments given ..
So it does, however that of itself differs from the unix norm; as with
this I cannot run checkpatch and "type" (ie paste) a patch fragment to
check it. So I don't think we want the semantics as you have there,
as its confusing to the experienced user and inconsistent with the norm.
Either we should document the standard '-' usage as has been suggested
elsewhere or always assume stdin with no parameters.
-apw
next prev parent reply other threads:[~2008-01-14 19:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080111041120.085610726@mvista.com>
2008-01-11 4:11 ` [PATCH] checkpatch.pl: allow piping Daniel Walker
2008-01-11 8:52 ` Jiri Slaby
2008-01-11 9:17 ` Daniel Walker
2008-01-11 9:21 ` Jiri Slaby
2008-01-11 9:23 ` Bernd Petrovitsch
2008-01-11 9:30 ` Daniel Walker
2008-01-11 9:34 ` Jiri Slaby
2008-01-11 9:36 ` Daniel Walker
2008-01-11 9:41 ` Jiri Slaby
2008-01-11 9:47 ` Daniel Walker
2008-01-11 10:11 ` Bernd Petrovitsch
2008-01-11 11:16 ` Stefan Richter
2008-01-11 11:50 ` Jiri Slaby
2008-01-11 17:06 ` [PATCH] checkpatch.pl: show how to read from stdin Stefan Richter
2008-01-11 17:09 ` Daniel Walker
2008-01-11 17:29 ` Stefan Richter
2008-01-11 17:39 ` Daniel Walker
2008-01-14 17:17 ` Andy Whitcroft
2008-01-14 17:35 ` Daniel Walker
2008-01-14 19:12 ` Andy Whitcroft [this message]
2008-01-14 19:17 ` Daniel Walker
2008-01-14 19:31 ` Stefan Richter
2008-01-14 19:44 ` Jiri Slaby
2008-01-14 19:51 ` Daniel Walker
2008-01-11 10:08 ` [PATCH] checkpatch.pl: allow piping Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114191243.GB25058@shadowen.org \
--to=apw@shadowen.org \
--cc=bernd@firmix.at \
--cc=dwalker@mvista.com \
--cc=jirislaby@gmail.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stefanr@s5r6.in-berlin.de \
--subject='Re: [PATCH] checkpatch.pl: show how to read from stdin' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).