LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Borislav Petkov <bbpetkov@yahoo.de> To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers Date: Tue, 15 Jan 2008 08:14:34 +0100 [thread overview] Message-ID: <20080115071434.GB32009@gollum.tnic> (raw) In-Reply-To: <200801142238.35893.bzolnier@gmail.com> On Mon, Jan 14, 2008 at 10:38:35PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sunday 13 January 2008, Borislav Petkov wrote: > > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by > > introducing a 4th arg. called direction. According to its value > > we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the > > interrupt handler logic a bit. Finally, rename idefloppy_io_buffers() to > > ide_floppy_io_buffers(). > > > > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> > > This change depends on "ide-floppy: use an xfer_func_t and io_buf_t typedefs > in order to unify rw" which was not in the "v2.5" series. Yep, this is correct. Probably i should've mentioned that in the preamble. It is rather confusing, imho, when sending only a subset of the patches. Rather, I should've sent the whole series after tagging the ones already applied so that you have an idea about their ordering. Will note that for the next time. > I took the patch #16/21 from the previous series and applied it manually > fixing rejects, please verify that I didn't brake something in the process. Will do the whole driver testing in the weekend. :) -- Regards/Gruß, Boris.
next prev parent reply other threads:[~2008-01-15 7:18 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-13 20:18 [PATCH 0/12] ide-floppy redux v2.5 Borislav Petkov 2008-01-13 20:18 ` [PATCH 1/12] ide-floppy: remove struct idefloppy_mode_parameter_header Borislav Petkov 2008-01-13 20:18 ` [PATCH 2/12] ide-floppy: remove struct idefloppy_flexible_disk_page Borislav Petkov 2008-01-13 20:18 ` [PATCH 3/12] ide-floppy: remove struct idefloppy_capacity_descriptor Borislav Petkov 2008-01-13 20:18 ` [PATCH 4/12] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Borislav Petkov 2008-01-13 20:18 ` [PATCH 5/12] ide-floppy: report DMA handling in idefloppy_pc_intr() properly Borislav Petkov 2008-01-13 20:18 ` [PATCH 6/12] ide-floppy: mv idefloppy_{should_,}report_error Borislav Petkov 2008-01-13 20:18 ` [PATCH 7/12] ide-floppy: remove IDEFLOPPY_DEBUG_BUGS macro Borislav Petkov 2008-01-13 20:18 ` [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers Borislav Petkov 2008-01-13 20:18 ` [PATCH 9/12] ide-floppy: remove unused IDEFLOPPY_USE_READ12 Borislav Petkov 2008-01-13 20:18 ` [PATCH 10/12] ide-floppy: remove atomic test_*bit macros Borislav Petkov 2008-01-13 20:18 ` [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO Borislav Petkov 2008-01-13 20:18 ` [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues Borislav Petkov 2008-01-15 20:12 ` (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2 Borislav Petkov 2008-01-16 22:51 ` Bartlomiej Zolnierkiewicz 2008-01-14 21:51 ` [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO Bartlomiej Zolnierkiewicz 2008-01-14 21:50 ` [PATCH 10/12] ide-floppy: remove atomic test_*bit macros Bartlomiej Zolnierkiewicz 2008-01-14 22:32 ` Bartlomiej Zolnierkiewicz 2008-01-15 20:09 ` Borislav Petkov 2008-01-16 22:08 ` Bartlomiej Zolnierkiewicz 2008-01-15 7:07 ` Borislav Petkov 2008-01-15 20:10 ` Borislav Petkov 2008-01-16 22:25 ` Bartlomiej Zolnierkiewicz 2008-01-14 21:38 ` [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers Bartlomiej Zolnierkiewicz 2008-01-15 7:14 ` Borislav Petkov [this message] 2008-01-14 21:38 ` [PATCH 0/12] ide-floppy redux v2.5 Bartlomiej Zolnierkiewicz 2008-01-20 12:38 ` Borislav Petkov 2008-01-21 22:45 ` Bartlomiej Zolnierkiewicz 2008-01-22 5:32 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080115071434.GB32009@gollum.tnic \ --to=bbpetkov@yahoo.de \ --cc=bzolnier@gmail.com \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).