LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: [patch] x86: lfence fix
Date: Tue, 15 Jan 2008 22:03:21 +0100	[thread overview]
Message-ID: <20080115210321.GA14757@elte.hu> (raw)
In-Reply-To: <20080115013858.GA25112@one.firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> I just tested x86.git and then x86.git + patch you send (+ build fixes 
> in both cases), none of your patchkits. If you want me to test some 
> other patchkit please point me to it.
> 
> The problem happens with plain git-x86 (+ build fixes) and also with 
> git-x86 + your patch.

i was held up from debugging your problem by a bug introduced by you 
into x86.git ;-) See the fix below.

	Ingo

----------------------------->
Subject: x86: lfence fix
From: Ingo Molnar <mingo@elte.hu>

LFENCE is available on XMM2 or higher Intel CPUs - not XMM or higher...

this caused boot failures on pre-XMM2 CPUs.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/intel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/kernel/cpu/intel.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/cpu/intel.c
+++ linux-x86.q/arch/x86/kernel/cpu/intel.c
@@ -206,7 +206,7 @@ static void __cpuinit init_intel(struct 
 	}
 #endif
 
-	if (cpu_has_xmm)
+	if (cpu_has_xmm2)
 		set_bit(X86_FEATURE_LFENCE_RDTSC, c->x86_capability);
 	if (c->x86 == 15) {
 		set_bit(X86_FEATURE_P4, c->x86_capability);

  reply	other threads:[~2008-01-15 21:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080114094814.GA28300@basil.nowhere.org>
2008-01-14 12:56 ` unify pagetable accessors patch causes double fault II Andi Kleen
2008-01-14 13:06   ` Ingo Molnar
2008-01-14 13:58     ` Andi Kleen
2008-01-14 16:44       ` Jeremy Fitzhardinge
2008-01-14 16:56         ` Ingo Molnar
2008-01-14 17:08           ` Andi Kleen
2008-01-14 17:18             ` unify pagetable accessors patch causes double fault III Andi Kleen
2008-01-14 19:00               ` Ingo Molnar
2008-01-14 19:54                 ` Jeremy Fitzhardinge
2008-01-14 20:15                 ` Andi Kleen
2008-01-14 19:52           ` unify pagetable accessors patch causes double fault II Jeremy Fitzhardinge
2008-01-14 22:03       ` Jeremy Fitzhardinge
2008-01-14 22:23         ` Andi Kleen
2008-01-14 22:46           ` Jeremy Fitzhardinge
2008-01-15  1:05             ` Andi Kleen
2008-01-15  1:32               ` Jeremy Fitzhardinge
2008-01-15  1:38                 ` Andi Kleen
2008-01-15 21:03                   ` Ingo Molnar [this message]
2008-01-16  0:44                     ` [patch] x86: lfence fix Andi Kleen
2008-01-15 12:55               ` unify pagetable accessors patch causes double fault II Ingo Molnar
2008-01-15 16:53                 ` Andi Kleen
2008-01-15 13:53             ` Ingo Molnar
2008-01-15 17:16               ` Folding _PAGE_PWT into _PAGE_PCD (was Re: unify pagetable accessors patch causes double fault II) Jeremy Fitzhardinge
2008-01-15 17:23                 ` Andi Kleen
2008-01-15 17:32                   ` Jeremy Fitzhardinge
2008-01-15 17:39                     ` Andi Kleen
2008-01-15 20:30                 ` Venki Pallipadi
2008-01-15 20:45                   ` Jeremy Fitzhardinge
2008-01-15 17:36               ` unify pagetable accessors patch causes double fault II Andi Kleen
2008-01-15 19:43                 ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080115210321.GA14757@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch] x86: lfence fix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).