LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org> To: Fengguang Wu <wfg@mail.ustc.edu.cn> Cc: Michael Rubin <mrubin@google.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] Converting writeback linked lists to a tree based data structure Date: Tue, 15 Jan 2008 21:51:49 -0800 [thread overview] Message-ID: <20080115215149.a881efff.akpm@linux-foundation.org> (raw) In-Reply-To: <400459376.04290@ustc.edu.cn> On Wed, 16 Jan 2008 12:55:07 +0800 Fengguang Wu <wfg@mail.ustc.edu.cn> wrote: > On Tue, Jan 15, 2008 at 08:42:36PM -0800, Andrew Morton wrote: > > On Wed, 16 Jan 2008 12:25:53 +0800 Fengguang Wu <wfg@mail.ustc.edu.cn> wrote: > > > > > list_heads are OK if we use them for one and only function. > > > > Not really. They're inappropriate when you wish to remember your > > position in the list while you dropped the lock (as we must do in > > writeback). > > > > A data structure which permits us to interate across the search key rather > > than across the actual storage locations is more appropriate. > > I totally agree with you. What I mean is to first do the split of > functions - into three: ordering, starvation prevention, and blockade > waiting. Does "ordering" here refer to ordering bt time-of-first-dirty? What is "blockade waiting"? > Then to do better ordering by adopting radix tree(or rbtree > if radix tree is not enough), ordering of what? > and lastly get rid of the list_heads to > avoid locking. Does it sound like a good path? I'd have thaought that replacing list_heads with another data structure would be a simgle commit.
next prev parent reply other threads:[~2008-01-16 5:52 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-15 8:09 [patch] Converting writeback linked lists to a tree based data structure Michael Rubin 2008-01-15 8:46 ` Peter Zijlstra 2008-01-15 17:53 ` Michael Rubin [not found] ` <400452490.28636@ustc.edu.cn> 2008-01-16 3:01 ` Fengguang Wu 2008-01-16 3:44 ` Andrew Morton [not found] ` <400457571.32162@ustc.edu.cn> 2008-01-16 4:25 ` Fengguang Wu 2008-01-16 4:42 ` Andrew Morton [not found] ` <400459376.04290@ustc.edu.cn> 2008-01-16 4:55 ` Fengguang Wu 2008-01-16 5:51 ` Andrew Morton [this message] [not found] ` <400474447.19383@ustc.edu.cn> 2008-01-16 9:07 ` Fengguang Wu 2008-01-16 22:35 ` David Chinner [not found] ` <400539769.00869@ustc.edu.cn> 2008-01-17 3:16 ` Fengguang Wu 2008-01-17 5:21 ` David Chinner 2008-01-18 7:36 ` Mike Waychison 2008-01-16 7:55 ` David Chinner 2008-01-16 8:13 ` Andrew Morton [not found] ` <400488821.15609@ustc.edu.cn> 2008-01-16 13:06 ` Fengguang Wu 2008-01-16 18:55 ` Michael Rubin [not found] ` <400540692.29046@ustc.edu.cn> 2008-01-17 3:31 ` Fengguang Wu [not found] ` <400562938.07583@ustc.edu.cn> 2008-01-17 9:41 ` Fengguang Wu 2008-01-17 21:07 ` Michael Rubin 2008-01-18 5:01 ` David Chinner 2008-01-18 5:38 ` Michael Rubin 2008-01-18 8:54 ` David Chinner 2008-01-18 9:26 ` Michael Rubin [not found] ` <400634919.20750@ustc.edu.cn> 2008-01-18 5:41 ` Fengguang Wu 2008-01-19 2:50 ` David Chinner [not found] ` <400632190.14601@ustc.edu.cn> 2008-01-18 4:56 ` Fengguang Wu 2008-01-18 5:41 ` Andi Kleen [not found] ` <400644314.11994@ustc.edu.cn> 2008-01-18 6:01 ` Fengguang Wu 2008-01-18 7:48 ` Mike Waychison 2008-01-18 6:43 ` Michael Rubin [not found] ` <400651538.20437@ustc.edu.cn> 2008-01-18 9:32 ` Fengguang Wu -- strict thread matches above, loose matches on Subject: below -- 2007-12-13 0:32 Michael Rubin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080115215149.a881efff.akpm@linux-foundation.org \ --to=akpm@linux-foundation.org \ --cc=a.p.zijlstra@chello.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mrubin@google.com \ --cc=wfg@mail.ustc.edu.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).