LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Peter Staubach <staubach@redhat.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Trond Myklebust <trond.myklebust@fys.uio.no>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/3] enhanced ESTALE error handling
Date: Fri, 18 Jan 2008 12:18:05 -0500	[thread overview]
Message-ID: <20080118171805.GA15158@fieldses.org> (raw)
In-Reply-To: <4790D7C0.30402@redhat.com>

On Fri, Jan 18, 2008 at 11:45:52AM -0500, Peter Staubach wrote:
> Matthew Wilcox wrote:
>> On Fri, Jan 18, 2008 at 10:36:01AM -0500, Peter Staubach wrote:
>>>  static int path_lookup_create(int dfd, const char *name,
>>> -			      unsigned int lookup_flags, struct nameidata *nd,
>>> -			      int open_flags, int create_mode)
>>> +		unsigned int lookup_flags, struct nameidata *nd,
>>> +		int open_flags, int create_mode)
>>>     
>>
>> Gratuitous reformatting?
>>
>>   
>
> Elimination of an overly long line?

I usually try to gather any coding style, comment grammar, etc., fixes
into a single patch or two at the beginning of a series.  That keeps the
substantive patches (the hardest to understand) shorter.

--b.

>
>>> @@ -1712,7 +1729,10 @@ int open_namei(int dfd, const char *path
>>>  	int acc_mode, error;
>>>  	struct path path;
>>>  	struct dentry *dir;
>>> -	int count = 0;
>>> +	int count;
>>> +
>>> +top:
>>> +	count = 0;
>>>   	acc_mode = ACC_MODE(flag);
>>>  @@ -1739,7 +1759,8 @@ int open_namei(int dfd, const char *path
>>>  	/*
>>>  	 * Create - we need to know the parent.
>>>  	 */
>>> -	error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,nd,flag,mode);
>>> +	error = path_lookup_create(dfd, pathname, LOOKUP_PARENT, nd,
>>> +				flag, mode);
>>>  	if (error)
>>>  		return error;
>>>  @@ -1812,10 +1833,17 @@ ok:
>>>  	return 0;
>>>   exit_dput:
>>> +	if (error == -ESTALE)
>>> +		d_drop(path.dentry);
>>>  	dput_path(&path, nd);
>>>  exit:
>>>  	if (!IS_ERR(nd->intent.open.file))
>>>  		release_open_intent(nd);
>>> +	if (error == -ESTALE) {
>>> +		d_drop(nd->dentry);
>>> +		path_release(nd);
>>> +		goto top;
>>> +	}
>>>     
>>
>> I wonder if a tail-call might not work better here.
>
> "Tail-call"?
>
>    Thanx...
>
>       ps
> -
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-01-18 17:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 15:36 Peter Staubach
2008-01-18 16:14 ` Matthew Wilcox
2008-01-18 16:45   ` Peter Staubach
2008-01-18 17:18     ` J. Bruce Fields [this message]
2008-01-18 17:32       ` Peter Staubach
2008-02-01 20:57 ` [PATCH 1/3] enhanced lookup ESTALE error handling (v2) Peter Staubach
2008-03-10 20:23   ` [PATCH 1/3] enhanced lookup ESTALE error handling (v3) Peter Staubach
2008-03-10 21:38     ` Andrew Morton
2008-03-10 22:03       ` Miklos Szeredi
2008-03-10 22:19         ` Dave Hansen
2008-03-11  4:12           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118171805.GA15158@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=staubach@redhat.com \
    --cc=trond.myklebust@fys.uio.no \
    --subject='Re: [PATCH 1/3] enhanced ESTALE error handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).