LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: travis@sgi.com To: Andrew Morton <akpm@linux-foundation.org>, Andi Kleen <ak@suse.de>, mingo@elte.hu Cc: Christoph Lameter <clameter@sgi.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] x86: Change bios_cpu_apicid to percpu data variable fixup Date: Fri, 18 Jan 2008 10:30:14 -0800 [thread overview] Message-ID: <20080118183011.788732000@sgi.com> (raw) In-Reply-To: 20080118183011.354965000@sgi.com [-- Attachment #1: change-bios_cpu_apicid-to-percpu-fixup --] [-- Type: text/plain, Size: 2542 bytes --] Change static bios_cpu_apicid array to a per_cpu data variable. This includes using a static array used during initialization similar to the way x86_cpu_to_apicid[] is handled. There is one early use of bios_cpu_apicid in apic_is_clustered_box(). The other reference in cpu_present_to_apicid() is called after smp_set_apicids() has setup the percpu version of bios_cpu_apicid. Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- V1->V2: - Removed extraneous casts - Add slight optimization to apic_is_clustered_box() [don't reference x86_bios_cpu_apicid_early_ptr each pass.] --- arch/x86/kernel/apic_64.c | 6 +++--- arch/x86/kernel/setup64.c | 3 +++ arch/x86/kernel/setup_64.c | 1 + 3 files changed, 7 insertions(+), 3 deletions(-) --- a/arch/x86/kernel/apic_64.c +++ b/arch/x86/kernel/apic_64.c @@ -1191,9 +1191,9 @@ __cpuinit int apic_is_clustered_box(void /* Problem: Partially populated chassis may not have CPUs in some of * the APIC clusters they have been allocated. Only present CPUs have - * x86_bios_cpu_apicid entries, thus causing zeroes in the bitmap. Since - * clusters are allocated sequentially, count zeros only if they are - * bounded by ones. + * x86_bios_cpu_apicid entries, thus causing zeroes in the bitmap. + * Since clusters are allocated sequentially, count zeros only if + * they are bounded by ones. */ clusters = 0; zeros = 0; --- a/arch/x86/kernel/setup64.c +++ b/arch/x86/kernel/setup64.c @@ -98,6 +98,8 @@ void __init setup_percpu_maps(void) #endif per_cpu(x86_cpu_to_apicid, cpu) = x86_cpu_to_apicid_init[cpu]; + per_cpu(x86_bios_cpu_apicid, cpu) = + x86_bios_cpu_apicid_init[cpu]; #ifdef CONFIG_NUMA per_cpu(x86_cpu_to_node_map, cpu) = x86_cpu_to_node_map_init[cpu]; @@ -112,6 +114,7 @@ void __init setup_percpu_maps(void) /* indicate the early static arrays are gone */ x86_cpu_to_apicid_early_ptr = NULL; + x86_bios_cpu_apicid_early_ptr = NULL; #ifdef CONFIG_NUMA x86_cpu_to_node_map_early_ptr = NULL; #endif --- a/arch/x86/kernel/setup_64.c +++ b/arch/x86/kernel/setup_64.c @@ -390,6 +390,7 @@ void __init setup_arch(char **cmdline_p) #ifdef CONFIG_SMP /* setup to use the early static init tables during kernel startup */ x86_cpu_to_apicid_early_ptr = (void *)&x86_cpu_to_apicid_init; + x86_bios_cpu_apicid_early_ptr = (void *)&x86_bios_cpu_apicid_init; #ifdef CONFIG_NUMA x86_cpu_to_node_map_early_ptr = (void *)&x86_cpu_to_node_map_init; #endif --
next prev parent reply other threads:[~2008-01-18 18:34 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-18 18:30 [PATCH 0/5] x86: Reduce memory usage for large count NR_CPUs fixup travis 2008-01-18 18:30 ` [PATCH 1/5] x86: Change size of node ids from u8 to u16 fixup travis 2008-01-18 19:56 ` Jan Engelhardt 2008-01-18 19:59 ` Mike Travis 2008-01-19 4:03 ` Yinghai Lu 2008-01-19 4:36 ` David Rientjes 2008-01-19 4:43 ` Yinghai Lu 2008-01-19 5:17 ` David Rientjes 2008-01-19 6:20 ` Yinghai Lu 2008-01-19 21:25 ` Mike Travis 2008-01-19 22:33 ` David Rientjes 2008-01-20 0:41 ` Mike Travis 2008-01-20 1:31 ` Yinghai Lu 2008-01-20 6:22 ` David Rientjes 2008-01-18 18:30 ` [PATCH 2/5] x86: Change NR_CPUS arrays in numa_64 fixup travis 2008-01-18 18:30 ` travis [this message] 2008-01-18 18:30 ` [PATCH 4/5] x86: Add config variables for SMP_MAX travis 2008-01-18 20:04 ` Ingo Oeser 2008-01-18 20:10 ` Christoph Lameter 2008-01-18 20:14 ` Mike Travis 2008-01-18 20:36 ` Andi Kleen 2008-01-18 20:48 ` Mike Travis 2008-01-18 21:02 ` [PATCH 4/5] x86: Add config variables for SMP_MAX II Andi Kleen 2008-01-18 20:48 ` [PATCH 4/5] x86: Add config variables for SMP_MAX Ingo Molnar 2008-01-18 20:55 ` Mike Travis 2008-01-18 20:58 ` Andi Kleen 2008-01-28 16:45 ` Paul Jackson 2008-01-28 17:00 ` Andi Kleen 2008-01-18 20:46 ` Ingo Molnar 2008-01-19 14:52 ` Ingo Molnar 2008-01-19 15:15 ` Ingo Molnar 2008-01-19 15:24 ` Ingo Molnar 2008-01-19 21:52 ` Mike Travis 2008-01-19 23:24 ` Mike Travis 2008-01-20 1:14 ` Mike Travis 2008-01-19 21:39 ` Mike Travis 2008-01-18 18:30 ` [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses travis 2008-01-18 18:33 ` Andi Kleen 2008-01-18 18:49 ` Mike Travis 2008-01-18 18:56 ` Christoph Lameter 2008-01-18 20:49 ` Ingo Molnar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080118183011.788732000@sgi.com \ --to=travis@sgi.com \ --cc=ak@suse.de \ --cc=akpm@linux-foundation.org \ --cc=clameter@sgi.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@elte.hu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).