LKML Archive on
help / color / mirror / Atom feed
From: Greg KH <>
To: Jan Beulich <>
Cc: lkml <>,
	Greg Kroah-Hartman <>
Subject: Re: [PATCH 3/4] introduce __devinitconst
Date: Fri, 18 Jan 2008 17:28:07 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jan 11, 2008 at 01:57:27AM -0700, Jan Beulich wrote:
> The drivers picked just serve as examples (which I routinely build and
> hence am able to easily verify), i.e. as before he patch doesn't change
> all instances where 'const' could have been added as a result of the
> base change, only where the change has a real effect (the module loader
> doesn't enforce read-only section attributes at present, so only
> built-in files make a real difference).

What does this buy us?

> --- 2.6.24-rc7-initconst.orig/include/linux/init.h
> +++ 2.6.24-rc7-initconst/include/linux/init.h
> @@ -257,11 +257,13 @@ void __init parse_early_param(void);
>  #define __devinit
>  #define __devinitdata
> +#define __devinitconst const
>  #define __devexit
>  #define __devexitdata
>  #else
>  #define __devinit __init
>  #define __devinitdata __initdata
> +#define __devinitconst __initdata

Shoudn't that be "__initdata const" or something like that?


greg k-h

  reply	other threads:[~2008-01-19  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2008-01-11  8:57 ` Jan Beulich
2008-01-19  1:28   ` Greg KH [this message]
2008-01-21 10:09     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH 3/4] introduce __devinitconst' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).