LKML Archive on
help / color / mirror / Atom feed
* [PATCH] Remove information leak in Linux CIFS client
@ 2008-01-19  4:55 Andi Kleen
  2008-01-19  8:18 ` [linux-cifs-client] " simo
  0 siblings, 1 reply; 7+ messages in thread
From: Andi Kleen @ 2008-01-19  4:55 UTC (permalink / raw)
  To: sfrench, linux-kernel, linux-cifs-client, samba-technical

Fix information leak in CIFS client lookup

Putting arbitary file names on lookup failures into the system log is not
a good idea, because usually everybody can read dmesg and that is thus
an information leak if a directory was read protected.

Also changed the error printout for this case to a signed number, because
it is normally negative and that makes it easier to read.

I'm not sure the message is all that useful anyways. Perhaps it 
should be just removed completely? Or at least rate limited because
it allows to spam the kernel log nicely.

Signed-off-by: Andi Kleen <>

Index: linux/fs/cifs/dir.c
--- linux.orig/fs/cifs/dir.c
+++ linux/fs/cifs/dir.c
@@ -518,7 +518,7 @@ cifs_lookup(struct inode *parent_dir_ino
 	/*	if it was once a directory (but how can we tell?) we could do
 		shrink_dcache_parent(direntry); */
 	} else {
-		cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s",
+		cERROR(1, ("Error %d on cifs_get_inode_info in lookup of file",
 			   rc, full_path));
 		/* BB special case check for Access Denied - watch security
 		exposure of returning dir info implicitly via different rc

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2008-01-20  0:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-19  4:55 [PATCH] Remove information leak in Linux CIFS client Andi Kleen
2008-01-19  8:18 ` [linux-cifs-client] " simo
2008-01-19 22:06   ` Steve French
2008-01-19 22:30     ` [linux-cifs-client] [PATCH] Remove information leak in Linux CIFS clientg Andi Kleen
2008-01-19 22:55       ` Steve French
2008-01-19 23:25         ` Andi Kleen
2008-01-20  0:32           ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).