LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] atm/suni.c: fix section mismatch
@ 2008-01-19 13:18 Adrian Bunk
  2008-01-19 13:29 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-01-19 13:18 UTC (permalink / raw)
  To: chas, jgarzik; +Cc: netdev, linux-kernel

EXPORT_SYMBOL'ed code mustn't be __*init.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
--- linux-2.6/drivers/atm/suni.c.old	2008-01-19 12:16:41.000000000 +0200
+++ linux-2.6/drivers/atm/suni.c	2008-01-19 12:17:23.000000000 +0200
@@ -275,35 +275,35 @@ static int suni_stop(struct atm_dev *dev
 	*walk = PRIV((*walk)->dev)->next;
 	if (!sunis) del_timer_sync(&poll_timer);
 	spin_unlock_irqrestore(&sunis_lock,flags);
 	kfree(PRIV(dev));
 
 	return 0;
 }
 
 
 static const struct atmphy_ops suni_ops = {
 	.start		= suni_start,
 	.ioctl		= suni_ioctl,
 	.interrupt	= suni_int,
 	.stop		= suni_stop,
 };
 
 
-int __devinit suni_init(struct atm_dev *dev)
+int suni_init(struct atm_dev *dev)
 {
 	unsigned char mri;
 
 	mri = GET(MRI); /* reset SUNI */
 	PUT(mri | SUNI_MRI_RESET,MRI);
 	PUT(mri,MRI);
 	PUT((GET(MT) & SUNI_MT_DS27_53),MT); /* disable all tests */
 	REG_CHANGE(SUNI_TPOP_APM_S,SUNI_TPOP_APM_S_SHIFT,SUNI_TPOP_S_SONET,
 	    TPOP_APM); /* use SONET */
 	REG_CHANGE(SUNI_TACP_IUCHP_CLP,0,SUNI_TACP_IUCHP_CLP,
 	    TACP_IUCHP); /* idle cells */
 	PUT(SUNI_IDLE_PATTERN,TACP_IUCPOP);
 	dev->phy = &suni_ops;
 	return 0;
 }
 
 EXPORT_SYMBOL(suni_init);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] atm/suni.c: fix section mismatch
  2008-01-19 13:18 [2.6 patch] atm/suni.c: fix section mismatch Adrian Bunk
@ 2008-01-19 13:29 ` Sam Ravnborg
  2008-01-21  1:23   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2008-01-19 13:29 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: chas, jgarzik, netdev, linux-kernel

On Sat, Jan 19, 2008 at 03:18:51PM +0200, Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> ---
> --- linux-2.6/drivers/atm/suni.c.old	2008-01-19 12:16:41.000000000 +0200
> +++ linux-2.6/drivers/atm/suni.c	2008-01-19 12:17:23.000000000 +0200
> @@ -275,35 +275,35 @@ static int suni_stop(struct atm_dev *dev
>  	*walk = PRIV((*walk)->dev)->next;
>  	if (!sunis) del_timer_sync(&poll_timer);
>  	spin_unlock_irqrestore(&sunis_lock,flags);
>  	kfree(PRIV(dev));
>  
>  	return 0;
>  }
>  
>  
>  static const struct atmphy_ops suni_ops = {
>  	.start		= suni_start,
>  	.ioctl		= suni_ioctl,
>  	.interrupt	= suni_int,
>  	.stop		= suni_stop,
>  };
>  
>  
> -int __devinit suni_init(struct atm_dev *dev)
> +int suni_init(struct atm_dev *dev)
>  {
>  	unsigned char mri;
>  
>  	mri = GET(MRI); /* reset SUNI */
>  	PUT(mri | SUNI_MRI_RESET,MRI);
>  	PUT(mri,MRI);
>  	PUT((GET(MT) & SUNI_MT_DS27_53),MT); /* disable all tests */
>  	REG_CHANGE(SUNI_TPOP_APM_S,SUNI_TPOP_APM_S_SHIFT,SUNI_TPOP_S_SONET,
>  	    TPOP_APM); /* use SONET */
>  	REG_CHANGE(SUNI_TACP_IUCHP_CLP,0,SUNI_TACP_IUCHP_CLP,
>  	    TACP_IUCHP); /* idle cells */
>  	PUT(SUNI_IDLE_PATTERN,TACP_IUCPOP);
>  	dev->phy = &suni_ops;
>  	return 0;
>  }
>  
>  EXPORT_SYMBOL(suni_init);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] atm/suni.c: fix section mismatch
  2008-01-19 13:29 ` Sam Ravnborg
@ 2008-01-21  1:23   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-01-21  1:23 UTC (permalink / raw)
  To: sam; +Cc: bunk, chas, jgarzik, netdev, linux-kernel

From: Sam Ravnborg <sam@ravnborg.org>
Date: Sat, 19 Jan 2008 14:29:04 +0100

> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-01-21  1:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-19 13:18 [2.6 patch] atm/suni.c: fix section mismatch Adrian Bunk
2008-01-19 13:29 ` Sam Ravnborg
2008-01-21  1:23   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).