LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [UPDATED] WM97xx touchscreen drivers
@ 2008-01-18 16:26 Mark Brown
  2008-01-18 16:27 ` [PATCH] Core driver for WM97xx touchscreens Mark Brown
  0 siblings, 1 reply; 18+ messages in thread
From: Mark Brown @ 2008-01-18 16:26 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: linux-input, linux-kernel, Liam Girdwood, Rodolfo Giometti,
	Russell King, Marc Kleine-Budde, Ian Molton, Vincent Sanders,
	Andrew Zabolotny

This patch series adds support for the touchscreen controllers provided
by Wolfson Microelectronics WM97xx series chips in both polled and
streaming modes.  It has been updated to reflect feedback since the
submission last week, most substantially in that the Makefile has been
cleaned up and the pxa-wm97xx has been renamed to mainstone-wm97xx to
better reflect how system-specific it is.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH 1/6] Core driver for WM97xx touchscreens
@ 2008-02-08 11:27 Mark Brown
  2008-02-08 11:27 ` [PATCH] " Mark Brown
  0 siblings, 1 reply; 18+ messages in thread
From: Mark Brown @ 2008-02-08 11:27 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: linux-input, linux-kernel, Dmitry Baryshkov, Liam Girdwood,
	Graeme Gregory, Rodolfo Giometti, Russell King,
	Marc Kleine-Budde, Ian Molton, Vincent Sanders, Andrew Zabolotny

On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote:

> The probe error handling is not quite correct. When we reach the fragment
> above ret variable is 0 so if platfrom_device_alloc() fails we will return
> 0 and the device will be considered bound but in half-dead state. Please
> make sure that proper error is returned in all cases. Also please do not
> mix out of line and in-line error unwinding (input_free_device() should
> be called in the error path and if you are concerned about double-free
> after input_unregister_device() just set wm->input_dev to NULL there).

Thanks for the review, I've implemented these changes and will resubmit
as a followup to this e-mail, also including a change from Dmitry
Baryshkov to make the devices unnumbered.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] Core driver for WM97xx touchscreens
@ 2008-02-12  0:00 Pete MacKay
  2008-02-12  9:46 ` Mark Brown
  0 siblings, 1 reply; 18+ messages in thread
From: Pete MacKay @ 2008-02-12  0:00 UTC (permalink / raw)
  To: broonie, linux-kernel; +Cc: liam.girdwood

In wm97xx-core.c, should

> +int wm97xx_resume(struct device *dev)

be static?

Also, should

> +		if (wm->ts_use_count) {

have been changed to

> +		if (wm->input_dev->users) {

in this revised revision?

(Oops, that was repetitively redundant. :)



^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2008-02-12  9:47 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-18 16:26 [UPDATED] WM97xx touchscreen drivers Mark Brown
2008-01-18 16:27 ` [PATCH] Core driver for WM97xx touchscreens Mark Brown
2008-01-18 16:27   ` [PATCH] Add chip driver for WM9705 touchscreen Mark Brown
2008-01-18 16:27     ` [PATCH] Add chip driver for WM9712 touchscreen Mark Brown
2008-01-18 16:27       ` [PATCH] Add chip driver for WM9713 touchscreen Mark Brown
2008-01-18 16:27         ` [PATCH] Driver for WM97xx touchscreens in streaming mode on Mainstone Mark Brown
2008-01-18 16:27           ` [PATCH] Build system and MAINTAINERS entry for WM97xx touchscreen drivers Mark Brown
2008-01-18 17:23   ` [PATCH] Core driver for WM97xx touchscreens Dmitry Torokhov
2008-01-18 18:11     ` Dmitry Baryshkov
2008-01-18 21:57       ` Ben Dooks
2008-01-19 19:53         ` Dmitry Baryshkov
2008-01-19 17:00       ` Mark Brown
2008-01-19 19:48         ` Dmitry
2008-01-19 21:55           ` Mark Brown
2008-01-19 22:18             ` Dmitry
2008-02-08 11:27 [PATCH 1/6] " Mark Brown
2008-02-08 11:27 ` [PATCH] " Mark Brown
2008-02-12  0:00 Pete MacKay
2008-02-12  9:46 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).