LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	liam.girdwood@wolfsonmicro.com
Subject: Re: [PATCH] Core driver for WM97xx touchscreens
Date: Sat, 19 Jan 2008 21:55:07 +0000	[thread overview]
Message-ID: <20080119215506.GA7400@sirena.org.uk> (raw)
In-Reply-To: <bc64b4640801191148m39ae5cd6ra190ac8e9c40fba7@mail.gmail.com>

On Sat, Jan 19, 2008 at 10:48:32PM +0300, Dmitry wrote:

> Well... It's a common suggestion not to duplicate code. The wm97xx bus
> looks mostly like platform. The only difference is the name. To help
> visualisation, devices can have parents. Just set (in pseudocode)
> wm97xx-touchscreen->parent to wm97xx, do the same for wm97xx-battery
> and so on. Thus all devices would be on the platform device but with
> proper parent <-> child notation.

That's exactly what I had understood you to mean.  I guess it's just
that using the platform bus for this purpose feels like an abstraction
violation to me due to having platform devices parented off a device on
another bus.  Obviously it's just my model of a platform device that's
wrong here.  I will change the driver to use the platform bus for my
next submission.

> git://git.mnementh.co.uk/linux-2.6-im.git#tmio_dev_try3. Look for

Thanks, I'll take a look.

> 2008/1/19, Mark Brown <broonie@opensource.wolfsonmicro.com>:

> > current patch series these chips all also provide an audio codec which
> > requires a reasonably substantial driver for full support.

> This would only touch child devices organisation.

Indeed - I mention it mostly for additional motivation.

  reply	other threads:[~2008-01-19 21:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 16:26 [UPDATED] WM97xx touchscreen drivers Mark Brown
2008-01-18 16:27 ` [PATCH] Core driver for WM97xx touchscreens Mark Brown
2008-01-18 16:27   ` [PATCH] Add chip driver for WM9705 touchscreen Mark Brown
2008-01-18 16:27     ` [PATCH] Add chip driver for WM9712 touchscreen Mark Brown
2008-01-18 16:27       ` [PATCH] Add chip driver for WM9713 touchscreen Mark Brown
2008-01-18 16:27         ` [PATCH] Driver for WM97xx touchscreens in streaming mode on Mainstone Mark Brown
2008-01-18 16:27           ` [PATCH] Build system and MAINTAINERS entry for WM97xx touchscreen drivers Mark Brown
2008-01-18 17:23   ` [PATCH] Core driver for WM97xx touchscreens Dmitry Torokhov
2008-01-18 18:11     ` Dmitry Baryshkov
2008-01-18 21:57       ` Ben Dooks
2008-01-19 19:53         ` Dmitry Baryshkov
2008-01-19 17:00       ` Mark Brown
2008-01-19 19:48         ` Dmitry
2008-01-19 21:55           ` Mark Brown [this message]
2008-01-19 22:18             ` Dmitry
2008-02-08 11:27 [PATCH 1/6] " Mark Brown
2008-02-08 11:27 ` [PATCH] " Mark Brown
2008-02-12  0:00 Pete MacKay
2008-02-12  9:46 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080119215506.GA7400@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=dbaryshkov@gmail.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] Core driver for WM97xx touchscreens' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).