LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 6/6] spi : use class iteration api
Date: Mon, 21 Jan 2008 23:41:50 -0800	[thread overview]
Message-ID: <200801212341.50999.david-b@pacbell.net> (raw)
In-Reply-To: <20080122071418.GA3725@darkstar.te-china.tietoenator.com>

On Monday 21 January 2008, Dave Young wrote:
> Convert to use the class iteration api.
> 
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 

Ack.


> ---
>  drivers/spi/spi.c |   24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 
> diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
> --- linux/drivers/spi/spi.c	2008-01-22 15:09:49.000000000 +0800
> +++ linux.new/drivers/spi/spi.c	2008-01-22 15:09:49.000000000 +0800
> @@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
>  }
>  EXPORT_SYMBOL_GPL(spi_unregister_master);
>  
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> +	struct spi_master *m;
> +	u16 *bus_num = data;
> +
> +	m = container_of(dev, struct spi_master, dev);
> +	return m->bus_num == *bus_num;
> +}
> +
>  /**
>   * spi_busnum_to_master - look up master associated with bus_num
>   * @bus_num: the master's bus number
> @@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
>  {
>  	struct device		*dev;
>  	struct spi_master	*master = NULL;
> -	struct spi_master	*m;
>  
> -	down(&spi_master_class.sem);
> -	list_for_each_entry(dev, &spi_master_class.children, node) {
> -		m = container_of(dev, struct spi_master, dev);
> -		if (m->bus_num == bus_num) {
> -			master = spi_master_get(m);
> -			break;
> -		}
> -	}
> -	up(&spi_master_class.sem);
> +	dev = class_find_device(&spi_master_class, &bus_num,
> +				__spi_master_match);
> +	if (dev)
> +		master = container_of(dev, struct spi_master, dev);
> +	/* reference got in class_find_device */
>  	return master;
>  }
>  EXPORT_SYMBOL_GPL(spi_busnum_to_master);
> 



      reply	other threads:[~2008-01-22  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-12  9:57 [PATCH 6/7] " Dave Young
2008-01-16  0:52 ` Dave Young
2008-01-22  6:03 ` [PATCH 6/6] " Dave Young
2008-01-22  6:56   ` David Brownell
2008-01-22  6:57     ` Dave Young
2008-01-22  7:14     ` Dave Young
2008-01-22  7:41       ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801212341.50999.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=gregkh@suse.de \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --subject='Re: [PATCH 6/6] spi : use class iteration api' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).