LKML Archive on
help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <>
To: Matthew Garrett <>
Cc: Zhang Rui <>,,,
Subject: Re: [PATCH] Rationalise ACPI backlight implementation
Date: Tue, 22 Jan 2008 10:39:23 -0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 22 Jan 2008, Matthew Garrett wrote:
> On Tue, Jan 22, 2008 at 04:33:29PM +0800, Zhang Rui wrote:
> > I have no obvious objection on either of these two proposals.
> > But one thing to mention is that
> > both of these two patches is written on the assumption that the
> > brightness levels listed in _BCL method are in ascending order, while
> > this is not stated in the ACPI spec.
> > Is this a problem?
> The driver already makes that assumption, and it's implicit in the spec.

Actually, no, it is not implicit.  The spec clearly states that the
brightness values will be cycled through the ones given by that list.  It is
implicit that brightness up actions will cycle through the list in order,
and brightness down will cycle through the list in reverse order.

If a vendor where to decide to place the most used brightness values in the
beginning of the list, and the rest of it later, he would be allowed to do
so.  Nobody was weird enough to do it yet though, AFAIK.

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2008-01-22 12:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26  2:03 Matthew Garrett
2008-01-14  1:51 ` Matthew Garrett
2008-01-22  8:33 ` Zhang Rui
2008-01-22 11:46   ` Matthew Garrett
2008-01-22 12:39     ` Henrique de Moraes Holschuh [this message]
2008-01-24 21:44 ` Len Brown
2008-01-27  2:06   ` Matthew Garrett
2008-01-27  6:00   ` Andrew Morton
2008-01-28  1:25     ` Matthew Garrett
2008-01-28  5:10       ` Andrew Morton
2008-01-28  5:28         ` Matthew Garrett
2008-01-28 15:51         ` Henrique de Moraes Holschuh
2008-02-02  3:46         ` Len Brown
2008-02-02 11:30           ` Henrique de Moraes Holschuh
2008-02-06 10:09             ` Romano Giannetti
2008-02-02  3:43 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Rationalise ACPI backlight implementation' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).