LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] drivers/base/core.c: fix a compile error
Date: Sun, 27 Jan 2008 11:40:53 -0800	[thread overview]
Message-ID: <20080127194053.GA17136@suse.de> (raw)
In-Reply-To: <20080126091445.GA20935@hacking>

On Sat, Jan 26, 2008 at 05:14:45PM +0800, WANG Cong wrote:
> On Fri, Jan 25, 2008 at 03:24:13PM -0800, Jeremy Fitzhardinge wrote:
> >Greg KH wrote:
> >>Ah, sorry, I missed that "note" :(
> >>
> >>thanks,
> >>
> >>greg 'time to get that make randconfig system up and working' k-h
> >>  
> >
> >Here's a config that fails.
> >
> 
> Here's one possible fix. Please review.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> 
> ---
> 
> Index: linux-2.6/include/linux/genhd.h
> ===================================================================
> --- linux-2.6.orig/include/linux/genhd.h
> +++ linux-2.6/include/linux/genhd.h
> @@ -12,6 +12,8 @@
>  #include <linux/types.h>
>  #include <linux/kdev_t.h>
>  
> +extern struct device_type part_type;
> +
>  #ifdef CONFIG_BLOCK
>  
>  #define kobj_to_dev(k) container_of(k, struct device, kobj)
> @@ -19,7 +21,6 @@
>  #define dev_to_part(device) container_of(device, struct hd_struct, dev)
>  
>  extern struct device_type disk_type;
> -extern struct device_type part_type;
>  extern struct kobject *block_depr;
>  extern struct class block_class;

No, that will fix the build error, but die when linking :(

I'll work on a real fix for this now...

thanks,

greg k-h

  reply	other threads:[~2008-01-27 19:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25 20:36 compile error in current git Jeremy Fitzhardinge
2008-01-25 22:17 ` Greg KH
2008-01-25 23:00   ` Randy Dunlap
2008-01-25 23:11     ` Greg KH
2008-01-25 23:24       ` Jeremy Fitzhardinge
2008-01-26  9:14         ` [Patch] drivers/base/core.c: fix a compile error WANG Cong
2008-01-27 19:40           ` Greg KH [this message]
2008-01-28  5:19             ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080127194053.GA17136@suse.de \
    --to=gregkh@suse.de \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=xiyou.wangcong@gmail.com \
    --subject='Re: [Patch] drivers/base/core.c: fix a compile error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).