LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2
Date: Sun, 27 Jan 2008 23:42:59 +0100 [thread overview]
Message-ID: <20080127224258.GA22018@elte.hu> (raw)
In-Reply-To: <479D067E.3010100@gmail.com>
* Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
> Looks like it would be better to proceed in the following manner:
>
> 1) remove dead code (no md5 change);
> 2) reformat the lines to use tabs, not spaces (no md5 change);
> 3) address the "else-braces" and "single statement block" errors
> (no md5 change);
> 4) remove all unnecessary spaces (no md5 change);
> 5) add the KERN_ macros (md5 will change).
> 6) address remaining checkpatch complaints (no md5 change wrt #5
> above).
>
> Each item above might get into a separate patch.
agreed, that looks like a sensible splitup for such larger cleanup
patches.
(also, a debug switch that disabled the FPU on modern CPUs and which
forced math-emu would be nice as well.)
Ingo
next prev parent reply other threads:[~2008-01-27 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 22:15 Paolo Ciarrocchi
2008-01-27 22:32 ` Dmitri Vorobiev
2008-01-27 22:38 ` Paolo Ciarrocchi
2008-01-27 22:42 ` Ingo Molnar [this message]
2008-01-27 22:48 ` Paolo Ciarrocchi
2008-01-27 23:57 ` Paolo Ciarrocchi
2008-01-28 0:20 ` Dmitri Vorobiev
2008-01-28 10:44 ` Ingo Molnar
2008-01-28 11:00 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080127224258.GA22018@elte.hu \
--to=mingo@elte.hu \
--cc=dmitri.vorobiev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
--subject='Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).