LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Steven Rostedt" <srostedt@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)
Date: Mon, 28 Jan 2008 12:32:36 +0100	[thread overview]
Message-ID: <200801281232.36838.rjw@sisk.pl> (raw)
In-Reply-To: <b647ffbd0801280056p71d939d4j882d640185c40d94@mail.gmail.com>

On Monday, 28 of January 2008, Dmitry Adamushko wrote:
> On 28/01/2008, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Sunday, 27 of January 2008, Ingo Molnar wrote:
> > >
> > > * Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > >
> > > > Hi,
> > > >
> > > > 2.6.24-git3 adds a 5 - 10 sec delay to the suspend and hibernation
> > > > code paths (probably related to the disabling of nonboot CPUs), which
> > > > is !@#$%^&*() annoying.
> > > >
> > > > It's 100% reproducible on my HP nx6325 and bisection idendified the
> > > > following commit as the first bad one:
> > > >
> > > > commit 764a9d6fe4b52995c8aba277e3634385699354f4
> > > > Author: Steven Rostedt <srostedt@redhat.com>
> > > > Date:   Fri Jan 25 21:08:04 2008 +0100
> > > >
> > > >     sched: track highest prio task queued
> > >
> > > hm, this patch is a NOP, so it's weird that it has an effect.
> > >
> > > Do you have serial logging enabled perhaps? If the following WARN_ON()
> > > triggers:
> > >
> > > +               WARN_ON(p->prio < rq->rt.highest_prio);
> > >
> > > then perhaps that can cause a 5-10 seconds delay. (that's how much time
> > > it takes to printk a warning on the slowest serial settings)
> > >
> > > but if you use suspend, then any such printks would be preserved in the
> > > dmesg, right? If the WARN_ON() triggers, and if you remove it, do things
> > > get faster?
> >
> > No, this isn't the WARN_ON().
> >
> > > this does have the feel of being scheduling related, but are you
> > > absolutely sure about the precise identity of the patch?
> >
> > Actually, not quite.  That's why I have verified it and found that another
> > patch is really responsible for the issue, namely:
> >
> > commit 82a1fcb90287052aabfa235e7ffc693ea003fe69
> > Author: Ingo Molnar <mingo@elte.hu>
> > Date:   Fri Jan 25 21:08:02 2008 +0100
> >
> >     softlockup: automatically detect hung TASK_UNINTERRUPTIBLE tasks
> >
> > Reverting this commit (it reverts with some minor modifications) fixes the
> > problem for me.
> 
> What if you use the same kernel that triggers a problem and just disable
> this new 'softlockup' functionality:
> 
> echo 0 > /proc/sys/kernel/hung_task_timeout_secs
> 
> does the problem disapear?

I haven't checked that yet, will do it later today.

Thanks,
Rafael

  reply	other threads:[~2008-01-28 11:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 21:29 [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected) Rafael J. Wysocki
2008-01-27 21:59 ` Ingo Molnar
2008-01-28  1:26   ` Rafael J. Wysocki
2008-01-28  1:40     ` Steven Rostedt
2008-01-28 11:31       ` Rafael J. Wysocki
2008-01-28 16:31         ` Rafael J. Wysocki
2008-01-28 16:46           ` Steven Rostedt
2008-01-29  0:08           ` Rafael J. Wysocki
2008-01-28  8:56     ` Dmitry Adamushko
2008-01-28 11:32       ` Rafael J. Wysocki [this message]
2008-01-28 16:08       ` Rafael J. Wysocki
2008-01-31 15:58     ` Peter Zijlstra
2008-01-31 20:54       ` Rafael J. Wysocki
2008-02-01 12:04         ` Peter Zijlstra
2008-02-01 12:47           ` Ingo Molnar
2008-02-01 14:42             ` Rafael J. Wysocki
2008-02-01 23:19               ` Rafael J. Wysocki
2008-02-01 23:24                 ` Ingo Molnar
2008-02-01 15:11           ` Dmitry Adamushko
2008-02-01 17:10             ` Ingo Molnar
2008-02-01 21:54               ` Dmitry Adamushko
2008-02-01 22:44                 ` Dmitry Adamushko
2008-02-01 22:48                   ` Ingo Molnar
2008-02-01 23:22                     ` Dmitry Adamushko
2008-02-01 23:25                       ` Ingo Molnar
2008-02-02  0:03                         ` Dmitry Adamushko
2008-02-01 23:26                       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801281232.36838.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).