LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: michael <trimarchi@gandalf.sssup.it>
Cc: linux-kernel@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
	David Brownell <david-b@pacbell.net>
Subject: Re: at91sam9260 wakeup on serial port
Date: Mon, 28 Jan 2008 14:56:15 +0100	[thread overview]
Message-ID: <20080128145615.1d756025@dhcp-252-066.norway.atmel.com> (raw)
In-Reply-To: <479DB934.6090806@gandalf.sssup.it>

On Mon, 28 Jan 2008 12:15:00 +0100
michael <trimarchi@gandalf.sssup.it> wrote:

> Hi,
> I implement a little patch (ndr just for a try) for the atmel serial 
> driver atmel_serial.c to wakeup the system when it is in suspend-ram state.
> I reconfigure the RXD pin as a gpio in suspend function and restore it 
> in the resume function. It is the correct way?

I'm not sure...this is rather platform-specific, so I don't think it
really belongs in the atmel_serial() driver. One solution might be to
add a function pointer to struct atmel_uart_data that the driver can
call from ->suspend() in order to let the platform code handle this as
appropriate.

Cc'ing Andrew Victor and David Brownell since they know the AT91
platform code better than me.

Haavard

  reply	other threads:[~2008-01-28 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 11:15 michael
2008-01-28 13:56 ` Haavard Skinnemoen [this message]
2008-01-28 18:21   ` David Brownell
2008-01-28 18:44     ` trimarchi
2008-01-28 18:51     ` Haavard Skinnemoen
2008-01-30  0:37       ` michael
2008-01-30  3:44       ` David Brownell
2008-01-30 11:47         ` Haavard Skinnemoen
2008-01-30 18:56           ` David Brownell
2008-01-30 20:34             ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080128145615.1d756025@dhcp-252-066.norway.atmel.com \
    --to=hskinnemoen@atmel.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=trimarchi@gandalf.sssup.it \
    --subject='Re: at91sam9260 wakeup on serial port' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).