LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Robin Holt <holt@sgi.com>, Avi Kivity <avi@qumranet.com>,
Izik Eidus <izike@qumranet.com>
Cc: Nick Piggin <npiggin@suse.de>, kvm-devel@lists.sourceforge.net
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: daniel.blueman@quadrics.com, Hugh Dickins <hugh@veritas.com>
Subject: [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c
Date: Mon, 28 Jan 2008 12:28:45 -0800 [thread overview]
Message-ID: <20080128202924.571345492@sgi.com> (raw)
In-Reply-To: <20080128202840.974253868@sgi.com>
[-- Attachment #1: mmu_xip --]
[-- Type: text/plain, Size: 1242 bytes --]
Problem for external rmaps: There is no pagelock held on the page.
Signed-off-by: Robin Holt <holt@sgi.com>
---
mm/filemap_xip.c | 5 +++++
1 file changed, 5 insertions(+)
Index: linux-2.6/mm/filemap_xip.c
===================================================================
--- linux-2.6.orig/mm/filemap_xip.c 2008-01-25 19:39:04.000000000 -0800
+++ linux-2.6/mm/filemap_xip.c 2008-01-25 19:39:06.000000000 -0800
@@ -13,6 +13,7 @@
#include <linux/module.h>
#include <linux/uio.h>
#include <linux/rmap.h>
+#include <linux/mmu_notifier.h>
#include <linux/sched.h>
#include <asm/tlbflush.h>
@@ -183,6 +184,9 @@ __xip_unmap (struct address_space * mapp
if (!page)
return;
+ if (PageExternalRmap(page))
+ mmu_rmap_notifier(invalidate_page, page);
+
spin_lock(&mapping->i_mmap_lock);
vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, pgoff, pgoff) {
mm = vma->vm_mm;
@@ -194,6 +198,7 @@ __xip_unmap (struct address_space * mapp
/* Nuke the page table entry. */
flush_cache_page(vma, address, pte_pfn(*pte));
pteval = ptep_clear_flush(vma, address, pte);
+ mmu_notifier(invalidate_page, mm, address);
page_remove_rmap(page, vma);
dec_mm_counter(mm, file_rss);
BUG_ON(pte_dirty(pteval));
--
next prev parent reply other threads:[~2008-01-28 20:29 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 20:28 [patch 0/6] [RFC] MMU Notifiers V2 Christoph Lameter
2008-01-28 20:28 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
2008-01-28 22:06 ` Christoph Lameter
2008-01-29 0:05 ` Robin Holt
2008-01-29 1:19 ` Christoph Lameter
2008-01-29 13:59 ` Andrea Arcangeli
2008-01-29 14:34 ` Andrea Arcangeli
2008-01-29 19:49 ` Christoph Lameter
2008-01-29 20:41 ` Avi Kivity
2008-01-29 16:07 ` Robin Holt
2008-02-05 18:05 ` Andy Whitcroft
2008-02-05 18:17 ` Peter Zijlstra
2008-02-05 18:19 ` Christoph Lameter
2008-01-28 20:28 ` [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-29 16:20 ` Andrea Arcangeli
2008-01-29 18:28 ` Andrea Arcangeli
2008-01-29 20:30 ` Christoph Lameter
2008-01-29 21:36 ` Andrea Arcangeli
2008-01-29 21:53 ` Christoph Lameter
2008-01-29 22:35 ` Andrea Arcangeli
2008-01-29 22:55 ` Christoph Lameter
2008-01-29 23:43 ` Andrea Arcangeli
2008-01-30 0:34 ` Christoph Lameter
2008-01-29 19:55 ` Christoph Lameter
2008-01-29 21:17 ` Andrea Arcangeli
2008-01-29 21:35 ` Christoph Lameter
2008-01-29 22:02 ` Andrea Arcangeli
2008-01-29 22:39 ` Christoph Lameter
2008-01-30 0:00 ` Andrea Arcangeli
2008-01-30 0:05 ` Andrea Arcangeli
2008-01-30 0:22 ` Christoph Lameter
2008-01-30 0:59 ` Andrea Arcangeli
2008-01-30 8:26 ` Peter Zijlstra
2008-01-30 0:20 ` Christoph Lameter
2008-01-30 0:28 ` Jack Steiner
2008-01-30 0:35 ` Christoph Lameter
2008-01-30 13:37 ` Andrea Arcangeli
2008-01-30 14:43 ` Jack Steiner
2008-01-30 19:41 ` Christoph Lameter
2008-01-30 20:29 ` Jack Steiner
2008-01-30 20:55 ` Christoph Lameter
2008-01-30 16:11 ` Robin Holt
2008-01-30 17:04 ` Andrea Arcangeli
2008-01-30 17:30 ` Robin Holt
2008-01-30 18:25 ` Andrea Arcangeli
2008-01-30 19:50 ` Christoph Lameter
2008-01-30 22:18 ` Robin Holt
2008-01-30 23:52 ` Andrea Arcangeli
2008-01-31 0:01 ` Christoph Lameter
2008-01-31 0:34 ` [kvm-devel] " Andrea Arcangeli
2008-01-31 1:46 ` Christoph Lameter
2008-01-31 2:34 ` Robin Holt
2008-01-31 2:37 ` Christoph Lameter
2008-01-31 2:56 ` [kvm-devel] mmu_notifier: invalidate_range_start with lock=1 Christoph Lameter
2008-01-31 10:52 ` [kvm-devel] [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges Andrea Arcangeli
2008-01-31 2:08 ` Christoph Lameter
2008-01-31 2:42 ` Andrea Arcangeli
2008-01-31 2:51 ` Christoph Lameter
2008-01-31 13:39 ` Andrea Arcangeli
2008-01-30 19:35 ` Christoph Lameter
2008-01-28 20:28 ` [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter
2008-01-29 16:28 ` Robin Holt
2008-01-28 20:28 ` [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps Christoph Lameter
2008-01-29 14:03 ` Andrea Arcangeli
2008-01-29 14:24 ` Andrea Arcangeli
2008-01-29 19:51 ` Christoph Lameter
2008-01-28 20:28 ` Christoph Lameter [this message]
2008-01-28 20:28 ` [patch 6/6] mmu_notifier: Add invalidate_all() Christoph Lameter
2008-01-29 16:31 ` Robin Holt
2008-01-29 20:02 ` Christoph Lameter
2008-01-30 2:29 [patch 0/6] [RFC] MMU Notifiers V3 Christoph Lameter
2008-01-30 2:29 ` [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128202924.571345492@sgi.com \
--to=clameter@sgi.com \
--cc=andrea@qumranet.com \
--cc=avi@qumranet.com \
--cc=holt@sgi.com \
--cc=izike@qumranet.com \
--subject='Re: [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).