LKML Archive on
help / color / mirror / Atom feed
From: Greg KH <>
To: Mark Fasheh <>
Cc: Linus Torvalds <>,
	Andrew Morton <>,,,
	Joel Becker <>
Subject: Re: [git pull] Fix recent Ocfs2 breakage
Date: Mon, 28 Jan 2008 21:08:04 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jan 28, 2008 at 07:33:07PM -0800, Mark Fasheh wrote:
> Greg's commit c60b71787982cefcf9fa09aa281fa8c4c685d557 inadvertantly broke
> Ocfs2 userspace ABI, so I have a rather high priority single line patch from
> Joel to fix things up for you to pull. A copy of the patch is attached to
> the bottom of this e-mail. Embarassingly enough, I missed this while acking
> the patch late last week :(
> Please pull from 'upstream-linus' branch of
> git:// upstream-linus
> to receive the following updates:
>  fs/ocfs2/cluster/sys.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> Joel Becker (1):
>       ocfs2: Fix userspace ABI breakage in sysfs

This is fine with me, for now.

> From: Joel Becker <>
> ocfs2: Fix userspace ABI breakage in sysfs
> The userspace ABI of ocfs2's internal cluster stack (o2cb) was broken by
> commit c60b71787982cefcf9fa09aa281fa8c4c685d557 "kset: convert ocfs2 to
> use kset_create".  Specifically, the '/sys/o2cb' kset was moved to
> '/sys/fs/o2cb'.  This breaks all ocfs2 tools and renders the
> filesystem unmountable.
> This fix moves '/sys/o2cb' back where it belongs.

"belongs" is pretty odd here.  This is a filesystem specific thing,
right?  Why not put it in /sys/fs/ then?

And yes, I understand about legacy userspace tools, that's why I have no
objection to it going back.  But you can put it in both places (with a
symlink) and change your userspace code, and in a year or so, drop the
symlink, right?

And please please please please document stuff like this, and all of the
different files you have in this subdirectory in Documentation/ABI/ so
those of us who are trying to figure out the code (and there's still
parts of the kobject usage I'm pretty sure is not correct) can have a
chance to understand exactly how this stuff is being used and expected
to work.


greg k-h

  reply	other threads:[~2008-01-29  5:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29  3:33 Mark Fasheh
2008-01-29  5:08 ` Greg KH [this message]
2008-01-29  5:58   ` Mark Fasheh
2008-01-29 17:50     ` Greg KH
2008-01-29  7:44   ` Joel Becker
2008-01-29 18:54     ` Greg KH
2008-01-29 22:18       ` Joel Becker
2008-01-29 22:22         ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [git pull] Fix recent Ocfs2 breakage' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).