LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com> To: Andrea Arcangeli <andrea@qumranet.com> Cc: Robin Holt <holt@sgi.com>, Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com> Cc: Nick Piggin <npiggin@suse.de>, kvm-devel@lists.sourceforge.net Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: daniel.blueman@quadrics.com, Hugh Dickins <hugh@veritas.com> Subject: [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps Date: Tue, 29 Jan 2008 18:29:13 -0800 [thread overview] Message-ID: <20080130022944.927685001@sgi.com> (raw) In-Reply-To: 20080130022909.677301714@sgi.com [-- Attachment #1: mmu_invalidate_page_callbacks --] [-- Type: text/plain, Size: 2465 bytes --] These notifiers here use the Linux rmaps to perform the callbacks. In order to walk the rmaps locks must be held. Callbacks can therefore only operate in an atomic context. Signed-off-by: Christoph Lameter <clameter@sgi.com> --- mm/rmap.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) Index: linux-2.6/mm/rmap.c =================================================================== --- linux-2.6.orig/mm/rmap.c 2008-01-29 16:58:25.000000000 -0800 +++ linux-2.6/mm/rmap.c 2008-01-29 16:58:39.000000000 -0800 @@ -285,7 +285,8 @@ static int page_referenced_one(struct pa if (!pte) goto out; - if (ptep_clear_flush_young(vma, address, pte)) + if (ptep_clear_flush_young(vma, address, pte) | + mmu_notifier_age_page(mm, address)) referenced++; /* Pretend the page is referenced if the task has the @@ -435,6 +436,7 @@ static int page_mkclean_one(struct page flush_cache_page(vma, address, pte_pfn(*pte)); entry = ptep_clear_flush(vma, address, pte); + mmu_notifier(invalidate_page, mm, address); entry = pte_wrprotect(entry); entry = pte_mkclean(entry); set_pte_at(mm, address, pte, entry); @@ -680,7 +682,8 @@ static int try_to_unmap_one(struct page * skipped over this mm) then we should reactivate it. */ if (!migration && ((vma->vm_flags & VM_LOCKED) || - (ptep_clear_flush_young(vma, address, pte)))) { + (ptep_clear_flush_young(vma, address, pte) | + mmu_notifier_age_page(mm, address)))) { ret = SWAP_FAIL; goto out_unmap; } @@ -688,6 +691,7 @@ static int try_to_unmap_one(struct page /* Nuke the page table entry. */ flush_cache_page(vma, address, page_to_pfn(page)); pteval = ptep_clear_flush(vma, address, pte); + mmu_notifier(invalidate_page, mm, address); /* Move the dirty bit to the physical page now the pte is gone. */ if (pte_dirty(pteval)) @@ -812,12 +816,14 @@ static void try_to_unmap_cluster(unsigne page = vm_normal_page(vma, address, *pte); BUG_ON(!page || PageAnon(page)); - if (ptep_clear_flush_young(vma, address, pte)) + if (ptep_clear_flush_young(vma, address, pte) | + mmu_notifier_age_page(mm, address)) continue; /* Nuke the page table entry. */ flush_cache_page(vma, address, pte_pfn(*pte)); pteval = ptep_clear_flush(vma, address, pte); + mmu_notifier(invalidate_page, mm, address); /* If nonlinear, store the file page offset in the pte. */ if (page->index != linear_page_index(vma, address)) --
next prev parent reply other threads:[~2008-01-30 2:30 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-30 2:29 [patch 0/6] [RFC] MMU Notifiers V3 Christoph Lameter 2008-01-30 2:29 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter 2008-01-30 15:37 ` Andrea Arcangeli 2008-01-30 15:53 ` Jack Steiner 2008-01-30 16:38 ` Andrea Arcangeli 2008-01-30 19:19 ` Christoph Lameter 2008-01-30 22:20 ` Robin Holt 2008-01-30 23:38 ` Andrea Arcangeli 2008-01-30 23:55 ` Christoph Lameter 2008-01-31 0:12 ` [kvm-devel] " Andrea Arcangeli 2008-01-31 1:27 ` Christoph Lameter 2008-01-30 17:10 ` Peter Zijlstra 2008-01-30 19:28 ` Christoph Lameter 2008-01-30 18:02 ` Robin Holt 2008-01-30 19:08 ` Christoph Lameter 2008-01-30 19:14 ` Christoph Lameter 2008-01-30 2:29 ` [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter 2008-01-30 2:29 ` [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter 2008-01-30 18:03 ` Robin Holt 2008-01-30 2:29 ` Christoph Lameter [this message] 2008-01-30 2:29 ` [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c Christoph Lameter 2008-01-30 2:29 ` [patch 6/6] mmu_notifier: Add invalidate_all() Christoph Lameter -- strict thread matches above, loose matches on Subject: below -- 2008-01-28 20:28 [patch 0/6] [RFC] MMU Notifiers V2 Christoph Lameter 2008-01-28 20:28 ` [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps Christoph Lameter 2008-01-29 14:03 ` Andrea Arcangeli 2008-01-29 14:24 ` Andrea Arcangeli 2008-01-29 19:51 ` Christoph Lameter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080130022944.927685001@sgi.com \ --to=clameter@sgi.com \ --cc=andrea@qumranet.com \ --cc=avi@qumranet.com \ --cc=holt@sgi.com \ --cc=izike@qumranet.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).