LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Jonas Bonn <jonas@southpole.se>,
	netdev@vger.kernel.org, romieu@fr.zoreil.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SIS190] Constify data marked as __devinitdata
Date: Wed, 30 Jan 2008 12:25:59 +0100	[thread overview]
Message-ID: <20080130112559.GA21346@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0801301220570.15249@fbirervta.pbzchgretzou.qr>

On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote:
> 
> On Jan 30 2008 11:53, Jonas Bonn wrote:
> >
> >This fixes build error as gcc complains about a "section type conflict"
> >due to the const __devinitdata in sis190_get_mac_addr_from_apc().
> 
> >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> >+static const struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> > 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
> > 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
> > 	{ 0, },
> 
> Eh? Did you mean to
> 
> -        static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
> +        static u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
> 
> instead? Because AFAIK, const *and* __sectionmarker does not mix.

We have just introduced __initconst, __cpuinitconst, __meminitconst
for const data.
So the patch is wrong.

	Sam

  reply	other threads:[~2008-01-30 11:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:53 Jonas Bonn
2008-01-30 11:23 ` Jan Engelhardt
2008-01-30 11:25   ` Sam Ravnborg [this message]
2008-01-30 11:57     ` [PATCH] [SIS190] Use _devinitconst for const data Jonas Bonn
2008-01-30 12:21       ` Sam Ravnborg
2008-01-30 13:31     ` [PATCH] [SIS190] Constify data marked as __devinitdata Jan Engelhardt
2008-01-30 13:37       ` Sam Ravnborg
2008-01-30 13:41         ` [PATCH] [SIS190] Use __devinitconst for const devinit data Jonas Bonn
2008-01-30 11:41   ` [PATCH] [SIS190] Constify data marked as __devinitdata Jonas Bonn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130112559.GA21346@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=jengelh@computergmbh.de \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --subject='Re: [PATCH] [SIS190] Constify data marked as __devinitdata' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).