LKML Archive on
help / color / mirror / Atom feed
From: Rob Landley <>
To: Ralf Baechle <>
Subject: Re: [PATCH 1/2] IRQ_NOPROBE helper functions
Date: Thu, 31 Jan 2008 01:56:28 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tuesday 29 January 2008 05:20:48 Ralf Baechle wrote:
> Probing non-ISA interrupts using the handle_percpu_irq as their handle_irq
> method may crash the system because handle_percpu_irq does not check
> IRQ_WAITING.  This for example hits the MIPS Qemu configuration.
> This patch provides two helper functions set_irq_noprobe and set_irq_probe
> to set rsp. clear the IRQ_NOPROBE flag.  The only current caller is MIPS
> code but this really belongs into generic code.
> As an aside, interrupt probing these days has become a mostly obsolete if
> not dangerous art.  I think Linux interrupts should be changed to default
> to non-probing but that's subject of this patch.
> Signed-off-by: Ralf Baechle <>

Acked-by: Rob Landley <>

To both patches: I can confirm that applying these two fixes together avoids 
the panic for me, although I thought qemu-system-mips used to have a working 
RTC, and I can't seem to find it now.  (Make is unhappy with 1970.  It was 
not a good year for make...)


"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

  parent reply	other threads:[~2008-01-31  7:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28  8:17 2.6.24 panics initializing ne2k in mips Rob Landley
2008-01-29  5:51 ` Rob Landley
2008-01-29 11:16 ` Ralf Baechle
2008-01-29 11:20   ` [PATCH 1/2] IRQ_NOPROBE helper functions Ralf Baechle
2008-01-29 11:21     ` [PATCH 2/2] MIPS: Mark all but i8259 interrupts as no-probe Ralf Baechle
2008-01-31  7:56     ` Rob Landley [this message]
2008-02-22 14:17   ` 2.6.24 panics initializing ne2k in mips Samuel Masham
2008-02-22 22:19     ` Rob Landley
2008-02-23  7:56       ` Samuel Masham
2008-02-23 21:43         ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).