LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: 2.6.24-git4+ regression
Date: Thu, 31 Jan 2008 11:29:19 +0100	[thread overview]
Message-ID: <20080131102919.GC27157@elte.hu> (raw)
In-Reply-To: <20080130135609.GA5100@ics.muni.cz>


* Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:

> I noticed short thread in LKM regarding "sched: add vslice" causes 
> horrible interactivity under load.
> 
> I can see similar behavior. If I stress both CPU cores, even typing on 
> keyboard suffers from huge latencies, I can see letters appearing with 
> delay (typing into xterm). No swap is used at all, having 1GB free 
> RAM.
> 
> I noticed this bad behavior with 2.6.24-git[46], 2.6.24-rc8-git was 
> OK.

if you apply the current sched-fixes (rollup patch below), does it get 
any better?

	Ingo

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -520,7 +520,7 @@ place_entity(struct cfs_rq *cfs_rq, stru
 
 	if (!initial) {
 		/* sleeps upto a single latency don't count. */
-		if (sched_feat(NEW_FAIR_SLEEPERS) && entity_is_task(se))
+		if (sched_feat(NEW_FAIR_SLEEPERS))
 			vruntime -= sysctl_sched_latency;
 
 		/* ensure we never gain time by being placed backwards. */
@@ -1106,7 +1106,11 @@ static void check_preempt_wakeup(struct 
 	}
 
 	gran = sysctl_sched_wakeup_granularity;
-	if (unlikely(se->load.weight != NICE_0_LOAD))
+	/*
+	 * More easily preempt - nice tasks, while not making
+	 * it harder for + nice tasks.
+	 */
+	if (unlikely(se->load.weight > NICE_0_LOAD))
 		gran = calc_delta_fair(gran, &se->load);
 
 	if (pse->vruntime + gran < se->vruntime)

  reply	other threads:[~2008-01-31 10:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 13:56 Lukas Hejtmanek
2008-01-31 10:29 ` Ingo Molnar [this message]
2008-01-31 10:55   ` Lukas Hejtmanek
2008-02-04 11:17   ` Lukas Hejtmanek
2008-02-04 11:36     ` Peter Zijlstra
2008-02-04 14:36       ` Lukas Hejtmanek
2008-02-04 14:45         ` Peter Zijlstra
2008-02-04 17:00           ` Lukas Hejtmanek
2008-02-04 12:01     ` Ingo Molnar
2008-02-04 12:29       ` Lukas Hejtmanek
2008-02-04 13:04         ` Ingo Molnar
2008-02-04 13:49           ` Lukas Hejtmanek
2008-02-14 16:55 ` Srivatsa Vaddagiri
2008-02-17 20:26   ` Lukas Hejtmanek
2008-02-18  4:28     ` Ingo Molnar
2008-02-18  7:38       ` Mike Galbraith
2008-02-18  8:20         ` Srivatsa Vaddagiri
2008-02-18  8:36           ` Mike Galbraith
     [not found]             ` <1203325554.4889.2.camel@homer.simson.net>
     [not found]               ` <1203345102.5984.1.camel@homer.simson.net>
2008-02-19  8:15                 ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131102919.GC27157@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=xhejtman@ics.muni.cz \
    --subject='Re: 2.6.24-git4+ regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).