LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: marcin.slusarz@gmail.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/10] udf: replace all adds to little endians variables with le*_add_cpu
Date: Thu, 31 Jan 2008 17:42:50 +0100	[thread overview]
Message-ID: <20080131164250.GG1461@duck.suse.cz> (raw)
In-Reply-To: <1201727040-6769-8-git-send-email-marcin.slusarz@gmail.com>

On Wed 30-01-08 22:03:57, marcin.slusarz@gmail.com wrote:
> replace all:
> 	little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
> 	                                    expression_in_cpu_byteorder);
> with:
> 	leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
> sparse didn't generate any new warning with this patch
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com
> Cc: Jan Kara <jack@suse.cz>
  Acked-by: Jan Kara <jack@suse.cz>

									Honza
> ---
>  fs/udf/balloc.c |   13 ++++---------
>  fs/udf/ialloc.c |   12 ++++--------
>  fs/udf/inode.c  |   16 ++++------------
>  3 files changed, 12 insertions(+), 29 deletions(-)
> 
> diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
> index d721a1a..a95fcfe 100644
> --- a/fs/udf/balloc.c
> +++ b/fs/udf/balloc.c
> @@ -149,8 +149,7 @@ static bool udf_add_free_space(struct udf_sb_info *sbi,
>  		return false;
>  
>  	lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
> -	lvid->freeSpaceTable[partition] = cpu_to_le32(le32_to_cpu(
> -					lvid->freeSpaceTable[partition]) + cnt);
> +	le32_add_cpu(&lvid->freeSpaceTable[partition], cnt);
>  	return true;
>  }
>  
> @@ -589,10 +588,8 @@ static void udf_table_free_blocks(struct super_block *sb,
>  					sptr = oepos.bh->b_data + epos.offset;
>  					aed = (struct allocExtDesc *)
>  						oepos.bh->b_data;
> -					aed->lengthAllocDescs =
> -						cpu_to_le32(le32_to_cpu(
> -							aed->lengthAllocDescs) +
> -								adsize);
> +					le32_add_cpu(&aed->lengthAllocDescs,
> +							adsize);
>  				} else {
>  					sptr = iinfo->i_ext.i_data +
>  								epos.offset;
> @@ -645,9 +642,7 @@ static void udf_table_free_blocks(struct super_block *sb,
>  				mark_inode_dirty(table);
>  			} else {
>  				aed = (struct allocExtDesc *)epos.bh->b_data;
> -				aed->lengthAllocDescs =
> -					cpu_to_le32(le32_to_cpu(
> -					    aed->lengthAllocDescs) + adsize);
> +				le32_add_cpu(&aed->lengthAllocDescs, adsize);
>  				udf_update_tag(epos.bh->b_data, epos.offset);
>  				mark_buffer_dirty(epos.bh);
>  			}
> diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c
> index 8436031..93b40cc 100644
> --- a/fs/udf/ialloc.c
> +++ b/fs/udf/ialloc.c
> @@ -47,11 +47,9 @@ void udf_free_inode(struct inode *inode)
>  		struct logicalVolIntegrityDescImpUse *lvidiu =
>  							udf_sb_lvidiu(sbi);
>  		if (S_ISDIR(inode->i_mode))
> -			lvidiu->numDirs =
> -				cpu_to_le32(le32_to_cpu(lvidiu->numDirs) - 1);
> +			le32_add_cpu(&lvidiu->numDirs, -1);
>  		else
> -			lvidiu->numFiles =
> -				cpu_to_le32(le32_to_cpu(lvidiu->numFiles) - 1);
> +			le32_add_cpu(&lvidiu->numFiles, -1);
>  
>  		mark_buffer_dirty(sbi->s_lvid_bh);
>  	}
> @@ -105,11 +103,9 @@ struct inode *udf_new_inode(struct inode *dir, int mode, int *err)
>  		lvhd = (struct logicalVolHeaderDesc *)
>  				(lvid->logicalVolContentsUse);
>  		if (S_ISDIR(mode))
> -			lvidiu->numDirs =
> -				cpu_to_le32(le32_to_cpu(lvidiu->numDirs) + 1);
> +			le32_add_cpu(&lvidiu->numDirs, 1);
>  		else
> -			lvidiu->numFiles =
> -				cpu_to_le32(le32_to_cpu(lvidiu->numFiles) + 1);
> +			le32_add_cpu(&lvidiu->numFiles, 1);
>  		iinfo->i_unique = uniqueID = le64_to_cpu(lvhd->uniqueID);
>  		if (!(++uniqueID & 0x00000000FFFFFFFFUL))
>  			uniqueID += 16;
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 3483274..68db2ea 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1778,9 +1778,7 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
>  
>  			if (epos->bh) {
>  				aed = (struct allocExtDesc *)epos->bh->b_data;
> -				aed->lengthAllocDescs =
> -					cpu_to_le32(le32_to_cpu(
> -					aed->lengthAllocDescs) + adsize);
> +				le32_add_cpu(&aed->lengthAllocDescs, adsize);
>  			} else {
>  				iinfo->i_lenAlloc += adsize;
>  				mark_inode_dirty(inode);
> @@ -1830,9 +1828,7 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
>  		mark_inode_dirty(inode);
>  	} else {
>  		aed = (struct allocExtDesc *)epos->bh->b_data;
> -		aed->lengthAllocDescs =
> -			cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) +
> -				    adsize);
> +		le32_add_cpu(&aed->lengthAllocDescs, adsize);
>  		if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
>  				UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
>  			udf_update_tag(epos->bh->b_data,
> @@ -2046,9 +2042,7 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos,
>  			mark_inode_dirty(inode);
>  		} else {
>  			aed = (struct allocExtDesc *)oepos.bh->b_data;
> -			aed->lengthAllocDescs =
> -				cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) -
> -					    (2 * adsize));
> +			le32_add_cpu(&aed->lengthAllocDescs, -(2 * adsize));
>  			if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
>  			    UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
>  				udf_update_tag(oepos.bh->b_data,
> @@ -2065,9 +2059,7 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos,
>  			mark_inode_dirty(inode);
>  		} else {
>  			aed = (struct allocExtDesc *)oepos.bh->b_data;
> -			aed->lengthAllocDescs =
> -				cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) -
> -					    adsize);
> +			le32_add_cpu(&aed->lengthAllocDescs, -adsize);
>  			if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
>  			    UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
>  				udf_update_tag(oepos.bh->b_data,
> -- 
> 1.5.3.7
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2008-01-31 16:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 21:03 [PATCH 00/10] udf: cleanups marcin.slusarz
2008-01-30 21:03 ` [PATCH 01/10] udf: udf_CS0toUTF8 cleanup marcin.slusarz
2008-01-31  9:57   ` Jan Kara
2008-01-30 21:03 ` [PATCH 02/10] udf: fix udf_build_ustr marcin.slusarz
2008-01-31 10:45   ` Jan Kara
2008-01-31 19:57     ` Marcin Slusarz
2008-02-04 19:31       ` Jan Kara
2008-02-04 21:27         ` Marcin Slusarz
2008-02-05 15:29           ` Jan Kara
2008-02-05 19:17             ` Marcin Slusarz
2008-01-30 21:03 ` [PATCH 03/10] udf: udf_CS0toNLS cleanup marcin.slusarz
2008-01-31 12:23   ` Jan Kara
2008-01-30 21:03 ` [PATCH 04/10] udf: constify crc marcin.slusarz
2008-01-31 12:58   ` Jan Kara
2008-01-30 21:03 ` [PATCH 05/10] udf: simple cleanup of truncate.c marcin.slusarz
2008-01-31 13:01   ` Jan Kara
2008-01-30 21:03 ` [PATCH 06/10] udf: truncate: create function for updating of Allocation Ext Descriptor marcin.slusarz
2008-01-31 17:08   ` Jan Kara
2008-01-31 18:18     ` Marcin Slusarz
2008-01-30 21:03 ` [PATCH 07/10] udf: replace all adds to little endians variables with le*_add_cpu marcin.slusarz
2008-01-31 16:42   ` Jan Kara [this message]
2008-01-30 21:03 ` [PATCH 08/10] udf: simplify __udf_read_inode marcin.slusarz
2008-01-31 16:46   ` Jan Kara
2008-01-30 21:03 ` [PATCH 09/10] udf: replace udf_*_offset macros with functions marcin.slusarz
2008-01-31 16:48   ` Jan Kara
2008-01-30 21:04 ` [PATCH 10/10] udf: constify udf_bitmap_lookup array marcin.slusarz
2008-01-31 16:52   ` Jan Kara
2008-02-02 21:37     ` Marcin Slusarz
2008-02-04 19:15       ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131164250.GG1461@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --subject='Re: [PATCH 07/10] udf: replace all adds to little endians variables with le*_add_cpu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).