Re: dl2k stopped working on 2.6.24

[Willy Tarreau <w@1wt.eu>]

Hi Santiago,

On Thu, Jan 31, 2008 at 10:55:41PM +0100, Santiago Garcia Mantinan wrote:
> As I didn't get any ideas on what to do to help find the problem with the
> dl2k driver, I'm doing some tests to get to know what has broken it.
> 
> I have today compiled dl2k from git, the version with the 2007-12-23 patches
> from Al Viro: dl2k endianness fixes (.24 fodder?) Right before the Al Viro
> patches. This seems to be working perfectly on my system.

I thought about those patches when you reported your problem but they
looked correct at first glance, and generally Al is known for pushing
clean and valid work.

> I'm wondering if I can apply the patches by Al Viro one by one to know which
> one broke it.

Yes it should be possible, people generally try to push incrementally
valid patches. Please CC Al with your findings. Maybe you'll get him
caught with a bug in his fixes, but get prepared to get fried on your
chair if you're wrong :-)

It is also possible that the code he fixed was really buggy but worked
because of another bug remaining somewhere else.

Regards,
Willy