LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Santiago Garcia Mantinan <manty@manty.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: dl2k stopped working on 2.6.24
Date: Thu, 31 Jan 2008 22:37:11 +0100	[thread overview]
Message-ID: <20080131213711.GM8953@1wt.eu> (raw)
In-Reply-To: <20080131215541.GA22018@dis.manty.net>

Hi Santiago,

On Thu, Jan 31, 2008 at 10:55:41PM +0100, Santiago Garcia Mantinan wrote:
> As I didn't get any ideas on what to do to help find the problem with the
> dl2k driver, I'm doing some tests to get to know what has broken it.
> 
> I have today compiled dl2k from git, the version with the 2007-12-23 patches
> from Al Viro: dl2k endianness fixes (.24 fodder?) Right before the Al Viro
> patches. This seems to be working perfectly on my system.

I thought about those patches when you reported your problem but they
looked correct at first glance, and generally Al is known for pushing
clean and valid work.

> I'm wondering if I can apply the patches by Al Viro one by one to know which
> one broke it.

Yes it should be possible, people generally try to push incrementally
valid patches. Please CC Al with your findings. Maybe you'll get him
caught with a bug in his fixes, but get prepared to get fried on your
chair if you're wrong :-)

It is also possible that the code he fixed was really buggy but worked
because of another bug remaining somewhere else.

Regards,
Willy


  reply	other threads:[~2008-01-31 22:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25 21:11 Santiago Garcia Mantinan
2008-01-28 23:33 ` Santiago Garcia Mantinan
2008-01-31 21:55   ` Santiago Garcia Mantinan
2008-01-31 21:37     ` Willy Tarreau [this message]
2008-02-01  0:04       ` Santiago Garcia Mantinan
2008-02-01  5:33         ` Al Viro
2008-02-01 16:43           ` Santiago Garcia Mantinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131213711.GM8953@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manty@manty.net \
    --subject='Re: dl2k stopped working on 2.6.24' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).