LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: "Kenichi Okuyama" <>
Subject: Re: [patch] NULL pointer check for vma->vm_mm
Date: Thu, 31 Jan 2008 23:55:44 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 1 Feb 2008 16:39:07 +0900 "Kenichi Okuyama" <> wrote:

> Dear all,
> I was looking at the ./mm/rmap.c .. I found that, in function
> "page_referenced_one()",
>    struct mm_struct *mm = vma->vm_mm;
> was being refererred without NULL check.
> Though I do agree that this works for most of the cases, I thought it
> is better to add
> BUG_ON() for case of mm being NULL.
> attached is the patch for this

If we dereference NULL then the kernel will display basically the same
information as would a BUG, and it takes the same action.  So adding a
BUG_ON here really doesn't gain us anything.

Also, I think vma->vm_mm == 0 is not a valid state, so this just shouldn't
happen - the code is OK to assume that a particular invariant is being

  reply	other threads:[~2008-02-01  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  7:39 Kenichi Okuyama
2008-02-01  7:55 ` Andrew Morton [this message]
2008-02-01  8:24   ` Kenichi Okuyama
2008-02-01 10:19     ` Andrew Morton
2008-02-01 17:39       ` Kenichi Okuyama

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [patch] NULL pointer check for vma->vm_mm' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).