LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* kill misleading comments in trampoline_*.S
@ 2008-02-01  0:54 Pavel Machek
  2008-02-01  1:02 ` Yinghai Lu
  2008-02-01 11:16 ` Ingo Molnar
  0 siblings, 2 replies; 4+ messages in thread
From: Pavel Machek @ 2008-02-01  0:54 UTC (permalink / raw)
  To: H. Peter Anvin, kernel list, Ingo Molnar



Both trampolines actually *do* set up stack. (Is the "we jump into
compressed/head.S" comment still true?)

Signed-off-by: Pavel Machek <pavel@suse.cz>
 
diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
index 9bcc1c6..5398547 100644
--- a/arch/x86/kernel/trampoline_32.S
+++ b/arch/x86/kernel/trampoline_32.S
@@ -11,9 +11,6 @@
  *	trampoline page to make our stack and everything else
  *	is a mystery.
  *
- *	In fact we don't actually need a stack so we don't
- *	set one up.
- *
  *	We jump into the boot/compressed/head.S code. So you'd
  *	better be running a compressed kernel image or you
  *	won't get very far.
diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
index e30b67c..4aedd0b 100644
--- a/arch/x86/kernel/trampoline_64.S
+++ b/arch/x86/kernel/trampoline_64.S
@@ -10,9 +10,6 @@
  *	trampoline page to make our stack and everything else
  *	is a mystery.
  *
- *	In fact we don't actually need a stack so we don't
- *	set one up.
- *
  *	On entry to trampoline_data, the processor is in real mode
  *	with 16-bit addressing and 16-bit data.  CS has some value
  *	and IP is zero.  Thus, data addresses need to be absolute

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kill misleading comments in trampoline_*.S
  2008-02-01  0:54 kill misleading comments in trampoline_*.S Pavel Machek
@ 2008-02-01  1:02 ` Yinghai Lu
  2008-02-01  1:05   ` Pavel Machek
  2008-02-01 11:16 ` Ingo Molnar
  1 sibling, 1 reply; 4+ messages in thread
From: Yinghai Lu @ 2008-02-01  1:02 UTC (permalink / raw)
  To: Pavel Machek; +Cc: H. Peter Anvin, kernel list, Ingo Molnar

On Jan 31, 2008 4:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
>
> Both trampolines actually *do* set up stack. (Is the "we jump into
> compressed/head.S" comment still true?)
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
> index 9bcc1c6..5398547 100644
> --- a/arch/x86/kernel/trampoline_32.S
> +++ b/arch/x86/kernel/trampoline_32.S
> @@ -11,9 +11,6 @@
>   *     trampoline page to make our stack and everything else
>   *     is a mystery.
>   *
> - *     In fact we don't actually need a stack so we don't
> - *     set one up.
> - *
>   *     We jump into the boot/compressed/head.S code. So you'd
>   *     better be running a compressed kernel image or you
>   *     won't get very far.

should be arch/x86/kernel/head_32.S

YH

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kill misleading comments in trampoline_*.S
  2008-02-01  1:02 ` Yinghai Lu
@ 2008-02-01  1:05   ` Pavel Machek
  0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2008-02-01  1:05 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: kernel list, Ingo Molnar, H. Peter Anvin

On Thu 2008-01-31 17:02:29, Yinghai Lu wrote:
> On Jan 31, 2008 4:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >
> >
> > Both trampolines actually *do* set up stack. (Is the "we jump into
> > compressed/head.S" comment still true?)
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> > diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
> > index 9bcc1c6..5398547 100644
> > --- a/arch/x86/kernel/trampoline_32.S
> > +++ b/arch/x86/kernel/trampoline_32.S
> > @@ -11,9 +11,6 @@
> >   *     trampoline page to make our stack and everything else
> >   *     is a mystery.
> >   *
> > - *     In fact we don't actually need a stack so we don't
> > - *     set one up.
> > - *
> >   *     We jump into the boot/compressed/head.S code. So you'd
> >   *     better be running a compressed kernel image or you
> >   *     won't get very far.
> 
> should be arch/x86/kernel/head_32.S

Thanks, fixed in my local copy. But that's separate problem. ;-).

								Pavel

diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
index 9bcc1c6..6458067 100644
--- a/arch/x86/kernel/trampoline_32.S
+++ b/arch/x86/kernel/trampoline_32.S
@@ -11,12 +11,7 @@
  *	trampoline page to make our stack and everything else
  *	is a mystery.
  *
- *	In fact we don't actually need a stack so we don't
- *	set one up.
- *
- *	We jump into the boot/compressed/head.S code. So you'd
- *	better be running a compressed kernel image or you
- *	won't get very far.
+ *	We jump into arch/x86/kernel/head_32.S.
  *
  *	On entry to trampoline_data, the processor is in real mode
  *	with 16-bit addressing and 16-bit data.  CS has some value
diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
index e30b67c..4aedd0b 100644
--- a/arch/x86/kernel/trampoline_64.S
+++ b/arch/x86/kernel/trampoline_64.S
@@ -10,9 +10,6 @@
  *	trampoline page to make our stack and everything else
  *	is a mystery.
  *
- *	In fact we don't actually need a stack so we don't
- *	set one up.
- *
  *	On entry to trampoline_data, the processor is in real mode
  *	with 16-bit addressing and 16-bit data.  CS has some value
  *	and IP is zero.  Thus, data addresses need to be absolute


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kill misleading comments in trampoline_*.S
  2008-02-01  0:54 kill misleading comments in trampoline_*.S Pavel Machek
  2008-02-01  1:02 ` Yinghai Lu
@ 2008-02-01 11:16 ` Ingo Molnar
  1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-02-01 11:16 UTC (permalink / raw)
  To: Pavel Machek; +Cc: H. Peter Anvin, kernel list


* Pavel Machek <pavel@ucw.cz> wrote:

> Both trampolines actually *do* set up stack. (Is the "we jump into 
> compressed/head.S" comment still true?)

thanks, applied. (v2 of this patch)

	Ingo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-01 11:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-01  0:54 kill misleading comments in trampoline_*.S Pavel Machek
2008-02-01  1:02 ` Yinghai Lu
2008-02-01  1:05   ` Pavel Machek
2008-02-01 11:16 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).