LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] latencytop s390 support.
@ 2008-02-01 13:08 Heiko Carstens
  2008-02-01 13:12 ` Ingo Molnar
  2008-02-01 13:30 ` Sam Ravnborg
  0 siblings, 2 replies; 3+ messages in thread
From: Heiko Carstens @ 2008-02-01 13:08 UTC (permalink / raw)
  To: Arjan van de Ven
  Cc: Martin Schwidefsky, Ingo Molnar, Holger Wolf, linux-kernel

Subject: [PATCH] latencytop s390 support.

From: Heiko Carstens <heiko.carstens@de.ibm.com>

Cc: Holger Wolf <wolf@linux.vnet.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---

Will go in via the s390 git tree if acceptable.

 arch/s390/Kconfig             |    3 +++
 arch/s390/kernel/stacktrace.c |   31 +++++++++++++++++++++++--------
 2 files changed, 26 insertions(+), 8 deletions(-)

Index: linux-2.6/arch/s390/Kconfig
===================================================================
--- linux-2.6.orig/arch/s390/Kconfig
+++ linux-2.6/arch/s390/Kconfig
@@ -20,6 +20,9 @@ config LOCKDEP_SUPPORT
 config STACKTRACE_SUPPORT
 	def_bool y
 
+config HAVE_LATENCYTOP_SUPPORT
+	def_bool y
+
 config RWSEM_GENERIC_SPINLOCK
 	bool
 
Index: linux-2.6/arch/s390/kernel/stacktrace.c
===================================================================
--- linux-2.6.orig/arch/s390/kernel/stacktrace.c
+++ linux-2.6/arch/s390/kernel/stacktrace.c
@@ -14,7 +14,8 @@
 static unsigned long save_context_stack(struct stack_trace *trace,
 					unsigned long sp,
 					unsigned long low,
-					unsigned long high)
+					unsigned long high,
+					int savesched)
 {
 	struct stack_frame *sf;
 	struct pt_regs *regs;
@@ -47,10 +48,12 @@ static unsigned long save_context_stack(
 			return sp;
 		regs = (struct pt_regs *)sp;
 		addr = regs->psw.addr & PSW_ADDR_INSN;
-		if (!trace->skip)
-			trace->entries[trace->nr_entries++] = addr;
-		else
-			trace->skip--;
+		if (savesched || !in_sched_functions(addr)) {
+			if (!trace->skip)
+				trace->entries[trace->nr_entries++] = addr;
+			else
+				trace->skip--;
+		}
 		if (trace->nr_entries >= trace->max_entries)
 			return sp;
 		low = sp;
@@ -66,15 +69,27 @@ void save_stack_trace(struct stack_trace
 	orig_sp = sp & PSW_ADDR_INSN;
 	new_sp = save_context_stack(trace, orig_sp,
 				    S390_lowcore.panic_stack - PAGE_SIZE,
-				    S390_lowcore.panic_stack);
+				    S390_lowcore.panic_stack, 1);
 	if (new_sp != orig_sp)
 		return;
 	new_sp = save_context_stack(trace, new_sp,
 				    S390_lowcore.async_stack - ASYNC_SIZE,
-				    S390_lowcore.async_stack);
+				    S390_lowcore.async_stack, 1);
 	if (new_sp != orig_sp)
 		return;
 	save_context_stack(trace, new_sp,
 			   S390_lowcore.thread_info,
-			   S390_lowcore.thread_info + THREAD_SIZE);
+			   S390_lowcore.thread_info + THREAD_SIZE, 1);
+}
+
+void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
+{
+	unsigned long sp, low, high;
+
+	sp = tsk->thread.ksp & PSW_ADDR_INSN;
+	low = (unsigned long) task_stack_page(tsk);
+	high = (unsigned long) task_pt_regs(tsk);
+	save_context_stack(trace, sp, low, high, 0);
+	if (trace->nr_entries < trace->max_entries)
+		trace->entries[trace->nr_entries++] = ULONG_MAX;
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] latencytop s390 support.
  2008-02-01 13:08 [PATCH] latencytop s390 support Heiko Carstens
@ 2008-02-01 13:12 ` Ingo Molnar
  2008-02-01 13:30 ` Sam Ravnborg
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-02-01 13:12 UTC (permalink / raw)
  To: Heiko Carstens
  Cc: Arjan van de Ven, Martin Schwidefsky, Holger Wolf, linux-kernel


* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> Subject: [PATCH] latencytop s390 support.

cool :-)

feel free to push the Kconfig cleanup as part of the s390 push. (if i 
dont manage to beat you at getting that patch to Linus today)

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] latencytop s390 support.
  2008-02-01 13:08 [PATCH] latencytop s390 support Heiko Carstens
  2008-02-01 13:12 ` Ingo Molnar
@ 2008-02-01 13:30 ` Sam Ravnborg
  1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2008-02-01 13:30 UTC (permalink / raw)
  To: Heiko Carstens
  Cc: Arjan van de Ven, Martin Schwidefsky, Ingo Molnar, Holger Wolf,
	linux-kernel

On Fri, Feb 01, 2008 at 02:08:11PM +0100, Heiko Carstens wrote:
> Subject: [PATCH] latencytop s390 support.
> 
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> Cc: Holger Wolf <wolf@linux.vnet.ibm.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> 
> Will go in via the s390 git tree if acceptable.
> 
>  arch/s390/Kconfig             |    3 +++
>  arch/s390/kernel/stacktrace.c |   31 +++++++++++++++++++++++--------
>  2 files changed, 26 insertions(+), 8 deletions(-)
> 
> Index: linux-2.6/arch/s390/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/s390/Kconfig
> +++ linux-2.6/arch/s390/Kconfig
> @@ -20,6 +20,9 @@ config LOCKDEP_SUPPORT
>  config STACKTRACE_SUPPORT
>  	def_bool y
>  
> +config HAVE_LATENCYTOP_SUPPORT
> +	def_bool y
> +

Same comment as for the x86 version.
Use:

 config S390
	select HAVE_....

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-01 13:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-01 13:08 [PATCH] latencytop s390 support Heiko Carstens
2008-02-01 13:12 ` Ingo Molnar
2008-02-01 13:30 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).