LKML Archive on
help / color / mirror / Atom feed
From: Sam Ravnborg <>
To: Alexander van Heukelum <>
	Alexander van Heukelum <>
Subject: Re: Avoid section mismatch involving arch_register_cpu
Date: Fri, 1 Feb 2008 16:03:12 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Alexander.

See below for my take on the same warning.
It is already in x86.git pending merge.

Comments welcome.


>From b7b4f3e109c742d32d255e04b7c2f90d08599ea8 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <>
Date: Sat, 26 Jan 2008 21:25:08 +0100
Subject: [PATCH] x86: fix section mismatch warning in topology.c

Fix following warning:
WARNING: arch/x86/kernel/built-in.o(__ksymtab+0x2b0): Section mismatch: reference to .cpuinit.text:arch_register_cpu in '__ksymtab_arch_register_cpu'

Annotating exported symbols are wrong.
Previously the warning were hidden by avoiding the export
in the non HOTPLUG_CPU case but the improved checks in
modpost caught it anyway.
Fix it by removing the __cpuinit annotation and rearrange the
code a bit to save one ifdef/endif pair.

Signed-off-by: Sam Ravnborg <>
 arch/x86/kernel/topology.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
index a0d1719..78cbb65 100644
--- a/arch/x86/kernel/topology.c
+++ b/arch/x86/kernel/topology.c
@@ -33,7 +33,8 @@
 static DEFINE_PER_CPU(struct x86_cpu, cpu_devices);
-int __cpuinit arch_register_cpu(int num)
+int arch_register_cpu(int num)
 	 * CPU0 cannot be offlined due to several
@@ -44,21 +45,23 @@ int __cpuinit arch_register_cpu(int num)
 	 * Also certain PCI quirks require not to enable hotplug control
 	 * for all CPU's.
 	if (num)
 		per_cpu(cpu_devices, num).cpu.hotpluggable = 1;
 	return register_cpu(&per_cpu(cpu_devices, num).cpu, num);
 void arch_unregister_cpu(int num)
 	return unregister_cpu(&per_cpu(cpu_devices, num).cpu);
+int arch_register_cpu(int num)
+	return register_cpu(&per_cpu(cpu_devices, num).cpu, num);
 static int __init topology_init(void)

  reply	other threads:[~2008-02-01 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 14:56 Alexander van Heukelum
2008-02-01 15:03 ` Sam Ravnborg [this message]
2008-02-01 15:21   ` Alexander van Heukelum
2008-02-01 16:37     ` Sam Ravnborg
2008-02-01 16:44 ` Sam Ravnborg
2008-02-01 16:51   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: Avoid section mismatch involving arch_register_cpu' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).