LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] x86: allow 64bit setting in Kconfig
Date: Fri, 1 Feb 2008 16:22:27 +0100	[thread overview]
Message-ID: <20080201152227.GB32085@elte.hu> (raw)
In-Reply-To: <20080128220944.GI8767@does.not.exist>


* Adrian Bunk <bunk@kernel.org> wrote:

>  # Select 32 or 64 bit
>  config 64BIT
> -	bool "64-bit kernel" if ARCH = "x86"
> +	bool "64-bit kernel"
>  	default ARCH = "x86_64"

NACK. You have just broken:

    make ARCH=i386 randconfig

on a 64-bit box that has a 32-bit .config in its kernel directory.

The randconfig/allyesconfig/allnoconfig variants override whatever is in 
the current .config. Making the result depend on whatever is in the 
.config at the moment is fundamentally wrong.

"oldconfig" on the other hand has correct sensitivity to the existing 
.config - and that always worked correctly. So if you pop a 32-bit or a 
64-bit .config into a kernel tree, that will be listened to, no matter 
whether you are on a 32-bit or on a 64-bit host.

	Ingo

  reply	other threads:[~2008-02-01 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 22:09 Adrian Bunk
2008-02-01 15:22 ` Ingo Molnar [this message]
2008-02-04 20:45   ` Adrian Bunk
2008-02-11 16:37     ` Ingo Molnar
2008-02-11 16:50       ` Adrian Bunk
2008-02-11 17:13         ` Sam Ravnborg
2008-02-11 17:30           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201152227.GB32085@elte.hu \
    --to=mingo@elte.hu \
    --cc=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [2.6 patch] x86: allow 64bit setting in Kconfig' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).