LKML Archive on
help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Adrian Bunk <>
	Andrew Morton <>,
	Linus Torvalds <>
Subject: Re: [2.6 patch] unexport touch_all_softlockup_watchdogs
Date: Fri, 1 Feb 2008 16:56:02 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080128221452.GL8767@does.not.exist>

* Adrian Bunk <> wrote:

> This patch removes the unused 
> EXPORT_SYMBOL(touch_all_softlockup_watchdogs).

NACK. Please use your brain Adrian, this is part of an API vector. 
Another similarly bogus patch you did is:

Either we unexport all of them, or none of them. Or we remove all 
aspects of an individual API call, or no aspects of it. You are sending 
export removal patches without apparently checking their contexts. This 
is the fourth bogus patch of yours that i've come across within a 24 
hour timeframe. Yes, sometimes unused symbol exports should be removed 
because they are just silly or unnecessary, but not all the time.

Same goes for your 'static' keyword patches. We should do it like the 
spelling fixes: send _one_ large 'add static' patch near the end of the 
release and we'll commit it without asking. Currently you are wasting a 
little bit from many people's time, by getting these tiny little "remove 
static" patches into every tree, every month, all the time. It's an 
utterly wasteful way to spend our time.

Perhaps you might want to spend some of your time to write some new, 
useful Linux kernel code and start maintaining it for a change, so that 
you can get the feel for the real problems and real issues that the 
Linux kernel is facing these days. Hint: it's not the extra exports and 
it's not the 'static' markers, and it's not the dead code either that 
you are removing so eagerly. You are not a newbie anymore.

      reply	other threads:[~2008-02-01 15:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 22:14 Adrian Bunk
2008-02-01 15:56 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [2.6 patch] unexport touch_all_softlockup_watchdogs' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).