LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/base: export (un)register_memory_notifier
@ 2008-02-01 16:16 Jan-Bernd Themann
  2008-02-01 17:18 ` Badari Pulavarty
  0 siblings, 1 reply; 2+ messages in thread
From: Jan-Bernd Themann @ 2008-02-01 16:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jan-Bernd Themann, Thomas Klein, Christoph Raisch, Marcus Eder,
	netdev, Badari Pulavarty, Stefan Roscher

Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>

---
 Comment: eHEA patches that exploit these functions will follow


 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..1e1bd4c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
-- 
1.5.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/base: export (un)register_memory_notifier
  2008-02-01 16:16 [PATCH] drivers/base: export (un)register_memory_notifier Jan-Bernd Themann
@ 2008-02-01 17:18 ` Badari Pulavarty
  0 siblings, 0 replies; 2+ messages in thread
From: Badari Pulavarty @ 2008-02-01 17:18 UTC (permalink / raw)
  To: Jan-Bernd Themann
  Cc: linux-kernel, Jan-Bernd Themann, Thomas Klein, Christoph Raisch,
	Marcus Eder, netdev, Stefan Roscher

On Fri, 2008-02-01 at 17:16 +0100, Jan-Bernd Themann wrote:
> Drivers like eHEA need memory notifiers in order to 
> update their internal DMA memory map when memory is added
> to or removed from the system.
> 
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
> 
> ---
>  Comment: eHEA patches that exploit these functions will follow
> 
> 
>  drivers/base/memory.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 7ae413f..1e1bd4c 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
>  {
>          return blocking_notifier_chain_register(&memory_chain, nb);
>  }
> +EXPORT_SYMBOL(register_memory_notifier);
> 
>  void unregister_memory_notifier(struct notifier_block *nb)
>  {
>          blocking_notifier_chain_unregister(&memory_chain, nb);
>  }
> +EXPORT_SYMBOL(unregister_memory_notifier);
> 
>  /*
>   * register_memory - Setup a sysfs device for a memory block

Is there a reason for not making them EXPORT_SYMBOL_GPL() ?
Otherwise, looks good to me.

I have been planning to send this as part of my next update
with ppc64 arch-specific remove support and generic __remove_pages()
support. If this is blocking your work, lets get this in.

Acked-by: Badari Pulavarty <pbadari@us.ibm.com>

Thanks,
Badari


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-01 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-01 16:16 [PATCH] drivers/base: export (un)register_memory_notifier Jan-Bernd Themann
2008-02-01 17:18 ` Badari Pulavarty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).