LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bastian Blank <bastian@waldi.eu.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ext4 bitops
Date: Fri, 1 Feb 2008 22:04:04 +0100	[thread overview]
Message-ID: <20080201210404.GA31271@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20080201122257.9524c2bb.akpm@linux-foundation.org>

On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:
> On Fri, 1 Feb 2008 21:02:08 +0100
> Bastian Blank <bastian@waldi.eu.org> wrote:
> 
> > Fix ext4 bitops.
> 
> This is incomplete.  Please tell us what was "fixed".
> 
> If it was a build error then please quote the compile error output in the
> changelog, as well as the usual description of what the problem is, and how
> it was fixed.

| fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy':
| fs/ext4/mballoc.c:954: error: implicit declaration of function 'generic_find_next_le_bit'

The s390 specific bitops uses parts of the generic implementation.
Include the correct header.

> > diff --git a/include/asm-s390/bitops.h b/include/asm-s390/bitops.h
> > index dba6fec..47844fc 100644
> > --- a/include/asm-s390/bitops.h
> > +++ b/include/asm-s390/bitops.h
> > @@ -762,6 +762,8 @@ static inline int sched_find_first_bit(unsigned long *b)
> >   *    23 22 21 20 19 18 17 16 31 30 29 28 27 26 25 24
> >   */
> >  
> > +#include <asm-generic/bitops/le.h>
> > +
> >  #define ext2_set_bit(nr, addr)       \
> >  	__test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (unsigned long *)addr)
> >  #define ext2_set_bit_atomic(lock, nr, addr)       \
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-s390" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
The idea of male and female are universal constants.
		-- Kirk, "Metamorphosis", stardate 3219.8

  reply	other threads:[~2008-02-01 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 20:02 Bastian Blank
2008-02-01 20:22 ` Andrew Morton
2008-02-01 21:04   ` Bastian Blank [this message]
2008-02-03 12:12     ` Heiko Carstens
2008-02-03 12:39       ` Geert Uytterhoeven
2008-02-04  4:50         ` Aneesh Kumar K.V
2008-02-04  9:24           ` Heiko Carstens
2008-02-04  9:29             ` Aneesh Kumar K.V
2008-02-04 20:11           ` Geert Uytterhoeven
2008-02-01 20:02 Bastian Blank
2008-02-03  7:36 ` Benjamin Herrenschmidt
2008-02-04  5:22 ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201210404.GA31271@wavehammer.waldi.eu.org \
    --to=bastian@waldi.eu.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --subject='Re: [PATCH] Fix ext4 bitops' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).