LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Atari Falcon IDE: Add missing hwif variable
@ 2008-01-27 13:29 Geert Uytterhoeven
  2008-02-01 21:49 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2008-01-27 13:29 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton, Bartlomiej Zolnierkiewicz,
	Sergei Shtylyov
  Cc: Linux/m68k, Linux Kernel Development

Atari Falcon IDE: Add missing hwif variable

Commit cbb010c180294a5242a7681555c28737d9dd26ab

    ide: drop 'initializing' argument from ide_register_hw()

    * Rename init_hwif_data() to ide_init_port_data() and export it.
    
    * For all users of ide_register_hw() with 'initializing' argument set
      hwif->present and hwif->hold are always zero so convert these host
      drivers to use ide_find_port()+ide_init_port_data()+ide_init_port_hw()
      instead (also no need for init_hwif_default() call since the setup
      done by it gets over-ridden by ide_init_port_hw() call).
    
    * Drop 'initializing' argument from ide_register_hw().
    
introduced the usage of a hwif variable, but forgot to declare the actual
variable.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
 drivers/ide/legacy/falconide.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/ide/legacy/falconide.c
+++ b/drivers/ide/legacy/falconide.c
@@ -66,6 +66,7 @@ static int __init falconide_init(void)
 {
     if (MACH_IS_ATARI && ATARIHW_PRESENT(IDE)) {
 	hw_regs_t hw;
+	ide_hwif_t *hwif;
 
 	printk(KERN_INFO "ide: Falcon IDE controller\n");
 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Atari Falcon IDE: Add missing hwif variable
  2008-01-27 13:29 [PATCH] Atari Falcon IDE: Add missing hwif variable Geert Uytterhoeven
@ 2008-02-01 21:49 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-01 21:49 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Torvalds, Andrew Morton, Sergei Shtylyov, Linux/m68k,
	Linux Kernel Development

On Sunday 27 January 2008, Geert Uytterhoeven wrote:
> Atari Falcon IDE: Add missing hwif variable
> 
> Commit cbb010c180294a5242a7681555c28737d9dd26ab
> 
>     ide: drop 'initializing' argument from ide_register_hw()
> 
>     * Rename init_hwif_data() to ide_init_port_data() and export it.
>     
>     * For all users of ide_register_hw() with 'initializing' argument set
>       hwif->present and hwif->hold are always zero so convert these host
>       drivers to use ide_find_port()+ide_init_port_data()+ide_init_port_hw()
>       instead (also no need for init_hwif_default() call since the setup
>       done by it gets over-ridden by ide_init_port_hw() call).
>     
>     * Drop 'initializing' argument from ide_register_hw().
>     
> introduced the usage of a hwif variable, but forgot to declare the actual
> variable.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-01 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-27 13:29 [PATCH] Atari Falcon IDE: Add missing hwif variable Geert Uytterhoeven
2008-02-01 21:49 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).