LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Steven Rostedt <srostedt@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Dmitry Adamushko <dmitry.adamushko@gmail.com>
Subject: Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)
Date: Sat, 2 Feb 2008 00:19:24 +0100	[thread overview]
Message-ID: <200802020019.25599.rjw@sisk.pl> (raw)
In-Reply-To: <200802011542.42483.rjw@sisk.pl>

On Friday, 1 of February 2008, Rafael J. Wysocki wrote:
> On Friday, 1 of February 2008, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > 
> > > The below fixes it for me..
> > > 
> > > ---
> > >  - restore the old wakeup mechanism
> > >  - fix break usage in do_each_thread() { } while_eac_thread().
> > >  - fix the hotplug switch stmt, a fall-through case was broken.
> > 
> > thanks Peter, i've picked your fix up. I hope this solves the problem 
> > for Rafael too.
> 
> No, it doesn't, unfortunately.  Actually, it breaks things even more, as
> suspend now hangs (probably deadlocks) while disabling the nonboot CPU.

For some obscure reason, I'm no longer able to reproduce the problem
with the Peter's patch and I think it's correct.  You can add

Tested-by: Rafael J. Wysocki <rjw@sisk.pl>

to it.

Thanks,
Rafael

  reply	other threads:[~2008-02-01 23:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 21:29 [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected) Rafael J. Wysocki
2008-01-27 21:59 ` Ingo Molnar
2008-01-28  1:26   ` Rafael J. Wysocki
2008-01-28  1:40     ` Steven Rostedt
2008-01-28 11:31       ` Rafael J. Wysocki
2008-01-28 16:31         ` Rafael J. Wysocki
2008-01-28 16:46           ` Steven Rostedt
2008-01-29  0:08           ` Rafael J. Wysocki
2008-01-28  8:56     ` Dmitry Adamushko
2008-01-28 11:32       ` Rafael J. Wysocki
2008-01-28 16:08       ` Rafael J. Wysocki
2008-01-31 15:58     ` Peter Zijlstra
2008-01-31 20:54       ` Rafael J. Wysocki
2008-02-01 12:04         ` Peter Zijlstra
2008-02-01 12:47           ` Ingo Molnar
2008-02-01 14:42             ` Rafael J. Wysocki
2008-02-01 23:19               ` Rafael J. Wysocki [this message]
2008-02-01 23:24                 ` Ingo Molnar
2008-02-01 15:11           ` Dmitry Adamushko
2008-02-01 17:10             ` Ingo Molnar
2008-02-01 21:54               ` Dmitry Adamushko
2008-02-01 22:44                 ` Dmitry Adamushko
2008-02-01 22:48                   ` Ingo Molnar
2008-02-01 23:22                     ` Dmitry Adamushko
2008-02-01 23:25                       ` Ingo Molnar
2008-02-02  0:03                         ` Dmitry Adamushko
2008-02-01 23:26                       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802020019.25599.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).