LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu> To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [patch 2/3] fuse: clean up setting i_size in write Date: Mon, 04 Feb 2008 18:04:12 +0100 [thread overview] Message-ID: <20080204170528.097544613@szeredi.hu> (raw) In-Reply-To: 20080204170409.991123259@szeredi.hu [-- Attachment #1: fuse_write_update_size.patch --] [-- Type: text/plain, Size: 1851 bytes --] From: Miklos Szeredi <mszeredi@suse.cz> Extract common code for setting i_size in write functions into a common helper. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- Index: linux/fs/fuse/file.c =================================================================== --- linux.orig/fs/fuse/file.c 2008-02-04 13:01:39.000000000 +0100 +++ linux/fs/fuse/file.c 2008-02-04 13:02:03.000000000 +0100 @@ -610,13 +610,24 @@ static int fuse_write_begin(struct file return 0; } +static void fuse_write_update_size(struct inode *inode, loff_t pos) +{ + struct fuse_conn *fc = get_fuse_conn(inode); + struct fuse_inode *fi = get_fuse_inode(inode); + + spin_lock(&fc->lock); + fi->attr_version = ++fc->attr_version; + if (pos > inode->i_size) + i_size_write(inode, pos); + spin_unlock(&fc->lock); +} + static int fuse_buffered_write(struct file *file, struct inode *inode, loff_t pos, unsigned count, struct page *page) { int err; size_t nres; struct fuse_conn *fc = get_fuse_conn(inode); - struct fuse_inode *fi = get_fuse_inode(inode); unsigned offset = pos & (PAGE_CACHE_SIZE - 1); struct fuse_req *req; @@ -643,12 +654,7 @@ static int fuse_buffered_write(struct fi err = -EIO; if (!err) { pos += nres; - spin_lock(&fc->lock); - fi->attr_version = ++fc->attr_version; - if (pos > inode->i_size) - i_size_write(inode, pos); - spin_unlock(&fc->lock); - + fuse_write_update_size(inode, pos); if (count == PAGE_CACHE_SIZE) SetPageUptodate(page); } @@ -766,12 +772,8 @@ static ssize_t fuse_direct_io(struct fil } fuse_put_request(fc, req); if (res > 0) { - if (write) { - spin_lock(&fc->lock); - if (pos > inode->i_size) - i_size_write(inode, pos); - spin_unlock(&fc->lock); - } + if (write) + fuse_write_update_size(inode, pos); *ppos = pos; } fuse_invalidate_attr(inode); --
next prev parent reply other threads:[~2008-02-04 17:05 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-04 17:04 [patch 0/3] add perform_write to a_ops Miklos Szeredi 2008-02-04 17:04 ` [patch 1/3] vfs: introduce perform_write in a_ops Miklos Szeredi 2008-02-04 17:04 ` Miklos Szeredi [this message] 2008-02-04 17:04 ` [patch 3/3] fuse: implement perform_write Miklos Szeredi 2008-02-04 19:39 ` [patch 0/3] add perform_write to a_ops Christoph Hellwig 2008-02-04 20:52 ` Miklos Szeredi 2008-02-04 20:59 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080204170528.097544613@szeredi.hu \ --to=miklos@szeredi.hu \ --cc=akpm@linux-foundation.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).