LKML Archive on
help / color / mirror / Atom feed
From: Christoph Hellwig <>
To: Miklos Szeredi <>
Subject: Re: [patch 0/3] add perform_write to a_ops
Date: Mon, 4 Feb 2008 15:59:52 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Feb 04, 2008 at 09:52:06PM +0100, Miklos Szeredi wrote:
> Moving up to higher layers might not be possible, due to lock/unlock
> of i_mutex being inside generic_file_aio_write().

Well some bits can be moved up.  Here's my grand plan which I plan
to implement once I get some time for it (or let someone else do
if they beat me):

 - generic_segment_checks goes to fs/read_write.c before caling into
   the filesystem
 - dito for vfs_check_frozen
 - generic_write_checks is a suitable helper already
 - dito for remove_suid
 - dito for file_update_time
 - after that there's not a whole lot left in generic_file_aio_write,
   except for direct I/O handling which will probably be very fs-specific
   if you have your own buffered I/O code

generic_file_buffered_write is an almost trivial wrapper around what's
->perform_write in Nick's earlier patches and a helper for the syncing

> But with fuse being the only user, it's not a huge issue duplicating
> some code.
> Nick, were there any other candidates, that would want to use such an
> interface in the future?
> Thanks,
> Miklos
> -
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to
> More majordomo info at
---end quoted text---

      reply	other threads:[~2008-02-04 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 17:04 [patch 0/3] add perform_write to a_ops Miklos Szeredi
2008-02-04 17:04 ` [patch 1/3] vfs: introduce perform_write in a_ops Miklos Szeredi
2008-02-04 17:04 ` [patch 2/3] fuse: clean up setting i_size in write Miklos Szeredi
2008-02-04 17:04 ` [patch 3/3] fuse: implement perform_write Miklos Szeredi
2008-02-04 19:39 ` [patch 0/3] add perform_write to a_ops Christoph Hellwig
2008-02-04 20:52   ` Miklos Szeredi
2008-02-04 20:59     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).