LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl> To: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org Cc: tong.n.li@intel.com, Peter Zijlstra <a.p.zijlstra@chello.nl> Subject: [PATCH 6/8] sched: rt-group: refure unrunnable tasks Date: Mon, 04 Feb 2008 22:03:04 +0100 [thread overview] Message-ID: <20080204211837.636773000@chello.nl> (raw) In-Reply-To: 20080204210258.118479000@chello.nl [-- Attachment #1: sched-rt-group-accept.patch --] [-- Type: text/plain, Size: 1198 bytes --] Refuse to accept or create RT tasks in groups that can't run them. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- kernel/sched.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) Index: linux-2.6/kernel/sched.c =================================================================== --- linux-2.6.orig/kernel/sched.c +++ linux-2.6/kernel/sched.c @@ -4588,6 +4588,15 @@ recheck: return -EPERM; } +#ifdef CONFIG_RT_GROUP_SCHED + /* + * Do not allow realtime tasks into groups that have no runtime + * assigned. + */ + if (rt_policy(policy) && task_group(p)->rt_runtime == 0) + return -EPERM; +#endif + retval = security_task_setscheduler(p, policy, param); if (retval) return retval; @@ -8005,9 +8014,15 @@ static int cpu_cgroup_can_attach(struct cgroup_subsys *ss, struct cgroup *cgrp, struct task_struct *tsk) { +#ifdef CONFIG_RT_GROUP_SCHED + /* Don't accept realtime tasks when there is no way for them to run */ + if (rt_task(tsk) && cgroup_tg(cgrp)->rt_runtime == 0) + return -EINVAL; +#else /* We don't support RT-tasks being in separate groups */ if (tsk->sched_class != &fair_sched_class) return -EINVAL; +#endif return 0; } --
next prev parent reply other threads:[~2008-02-04 21:19 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20080204210258.118479000@chello.nl> 2008-02-04 21:02 ` [PATCH 1/8] sched: fix incorrect irq lock usage in normalize_rt_tasks() Peter Zijlstra 2008-02-04 21:03 ` [PATCH 2/8] sched: rt-group: deal with PI Peter Zijlstra 2008-02-04 21:03 ` [PATCH 3/8] sched: rt-group: interface Peter Zijlstra 2008-02-06 1:31 ` Randy Dunlap 2008-02-23 19:48 ` Paul Menage 2008-02-23 19:57 ` Peter Zijlstra 2008-02-23 20:02 ` Paul Menage 2008-02-23 20:26 ` Peter Zijlstra 2008-02-23 20:36 ` Paul Menage 2008-02-04 21:03 ` [PATCH 4/8] sched: rt-group: make rt groups scheduling configurable Peter Zijlstra 2008-02-04 21:03 ` [PATCH 5/8] sched: rt-group: clean up the ifdeffery Peter Zijlstra 2008-02-04 21:03 ` Peter Zijlstra [this message] 2008-02-04 21:03 ` [PATCH 7/8] sched: rt-group: synchonised bandwidth period Peter Zijlstra 2008-02-04 21:03 ` [PATCH 8/8] sched: rt-group: smp balancing Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080204211837.636773000@chello.nl \ --to=a.p.zijlstra@chello.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=tong.n.li@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).