LKML Archive on
help / color / mirror / Atom feed
From: David Miller <>
Subject: more iommu sg merging fallout
Date: Tue, 05 Feb 2008 20:41:38 -0800 (PST)	[thread overview]
Message-ID: <> (raw)

The sparc64 change:

    commit fde6a3c82d67f592eb587be4d12222b0ae6d4321
    Author: FUJITA Tomonori <>
    Date:   Mon Feb 4 22:28:02 2008 -0800

    iommu sg merging: sparc64: make iommu respect the segment size limits
    This patch makes iommu respect segment size limits when merging sg
    Signed-off-by: FUJITA Tomonori <>
    Cc: Jeff Garzik <>
    Cc: James Bottomley <>
    Acked-by: Jens Axboe <>
    Cc: "David S. Miller" <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>

has significant errors and is going to eat people's disks, as it just
nearly did to mine.

Typically what you'll see are NULL pointer derefernces in
dma_4v_map_sg() and dma_4u_map_sg() and then the kernel usually craps
on your superblock very shortly thereafter.

The changeset above modified only prepare_sg() but that is only the
first pass of the SG mapping algorithm of the sparc64 IOMMU layer.

The second pass that fills in the entries depends upon how the first
pass does things.  So if you change the first pass decision making you
have to update the second pass's as well.

That second pass is implemented in fill_sg() (there is a version in
both arch/sparc64/kernel/iommu.c and arch/sparc64/kernel/pci_sun4v.c),
which probably needs new logic as was added to prepare_sg() to handle

             reply	other threads:[~2008-02-06  4:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  4:41 David Miller [this message]
2008-02-06 23:12 ` FUJITA Tomonori
2008-02-06 23:18   ` David Miller
2008-02-06 23:53     ` FUJITA Tomonori
2008-02-07  0:01       ` David Miller
2008-02-07  1:38         ` FUJITA Tomonori
2008-02-12  5:40           ` David Miller
2008-02-16  6:03             ` FUJITA Tomonori
2008-02-18  7:41               ` David Miller
2008-02-19 10:57                 ` FUJITA Tomonori
2008-02-21  6:56                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: more iommu sg merging fallout' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).