LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: greg@kroah.com, markus.rechberger@amd.com,
	"Matt_Domsch@dell.com" <Matt_Domsch@dell.com>,
	Jos?? Luis Tall??n <jltallon@adv-solutions.net>,
	"Douglas_Warzecha@dell.com" <Douglas_Warzecha@dell.com>,
	"Abhay_Salunke@dell.com" <Abhay_Salunke@dell.com>,
	linux-kernel@vger.kernel.org,
	Michael E Brown <Michael_E_Brown@dell.com>
Subject: Re: FW: 2.6.24 breaks BIOS updates on all Dell machines
Date: Mon, 4 Feb 2008 22:45:47 -0800	[thread overview]
Message-ID: <20080205064547.GA20384@suse.de> (raw)
In-Reply-To: <xJSmDwPr.1201644922.4322840.khali@gcu-squad.org>

On Tue, Jan 29, 2008 at 11:15:22PM +0100, Jean Delvare wrote:
> >So, I'm all for reverting this patch.
> >
> >And then, feel free to revisit the problem by proposing something that
> >doesn't break existing users of the interface.
> 
> I'm a bit confused. It seems to me that the "class devices" are named
> differently in recent kernels. The i2c-dev class devices were originally
> showing as i2c-%d in their parent device directories (causing the
> collision), and now show as i2c-dev:i2c-%d. This suggests that the
> collision the patch above was trying to solve is in fact already fixed
> (by prefixing the device name with the class name). The good news is
> that it would mean that we can just revert the patch in question...
> 
> But quite frankly I'm not really sure, the class devices look different
> on every kernel I looked at, depending on the version and whether
> CONFIG_SYSFS_DEPRECATED is set or not.

THe naming is different depending on that sysfs variable, yes.  But it
should be consistant other than that.  If not, please let me know.

And yes, we did have to add the ":" a while ago to handle the namespace
collisions we were having.

thanks,

greg k-h

  reply	other threads:[~2008-02-05  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E9909A75A543064DB66E55B8E3BE41EC5FD218@ausx3mps307.aus.amer.dell.com>
2008-01-29 14:59 ` Markus Rechberger
2008-01-29 18:41   ` Greg KH
2008-01-29 22:15     ` Jean Delvare
2008-02-05  6:45       ` Greg KH [this message]
2008-02-05 20:16         ` Jean Delvare
2008-02-05 23:44           ` Greg KH
2008-02-06 13:20             ` Jean Delvare
2008-01-29 19:04   ` FW: " Sytse Wielinga
     [not found]     ` <20080129190924.GB8786@humbolt.us.dell.com>
2008-02-03 14:02       ` Jean Delvare
     [not found]         ` <20080204155834.GA32437@humbolt.us.dell.com>
2008-02-05 16:25           ` Jean Delvare
     [not found] <20080129063244.GA19076@humbolt.us.dell.com>
2008-01-29  6:44 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080205064547.GA20384@suse.de \
    --to=gregkh@suse.de \
    --cc=Abhay_Salunke@dell.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=Matt_Domsch@dell.com \
    --cc=Michael_E_Brown@dell.com \
    --cc=greg@kroah.com \
    --cc=jltallon@adv-solutions.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.rechberger@amd.com \
    --subject='Re: FW: 2.6.24 breaks BIOS updates on all Dell machines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).