LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: locking api self-test hanging
Date: Tue, 5 Feb 2008 14:23:50 +0100	[thread overview]
Message-ID: <20080205132350.GB31523@suse.de> (raw)
In-Reply-To: <20080204050421.0febc754.akpm@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [2008-02-04 14:04]:
> 
> but that code really needs help.

Using spin_lock_irqsave() is what rtc_get_rtc_time() does which was
used before I changed to get_rtc_time() does. So it should be ok. I
missed that difference. However, I agree with you the whole RTC
"emulation" per HPET is a bit unclean. However, I have too little
experience in this code area to come up with a proper redesign. I just
ported it from the old RTC to the new RTC module interface.

> Bernhard, I believe the checklist items in Documentation/SubmitChecklist
> would have prevented this at the source.

Yes. I must admit that I didn't know that document. I used
checkpatch.pl, but that's of course only for coding style. I'll try to
follow the points in SubmitChecklist in future.



        Bernhard

  parent reply	other threads:[~2008-02-05 13:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 23:02 Andrew Morton
2008-02-03 23:07 ` Andrew Morton
2008-02-04 12:43   ` Andrew Morton
2008-02-04 13:04     ` Andrew Morton
2008-02-04 13:14       ` Peter Zijlstra
2008-02-05 13:23       ` Bernhard Walle [this message]
2008-02-04 13:18     ` Andrew Morton
2008-02-06  8:34     ` Andrew Morton
2008-02-06  9:16       ` Andrew Morton
2008-03-04  5:05         ` Andrew Morton
2008-03-04  8:06           ` [patch] mark netconsole broken Ingo Molnar
2008-03-04 16:19             ` Randy Dunlap
2008-03-04 20:30             ` David Miller
2008-03-04 20:52               ` Ingo Molnar
2008-03-04  8:40           ` locking api self-test hanging Jarek Poplawski
2008-03-04  9:10             ` Andrew Morton
2008-03-04 19:04           ` Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080205132350.GB31523@suse.de \
    --to=bwalle@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: locking api self-test hanging' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).