LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	r31dmaeu@pc0312b.rz.unibw-muenchen.de, stable@kernel.org
Subject: Re: [stable] OOM-killer invoked but why ?
Date: Tue, 5 Feb 2008 14:37:36 -0800	[thread overview]
Message-ID: <20080205223736.GA7404@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0802051412370.14665@schroedinger.engr.sgi.com>

On Tue, Feb 05, 2008 at 02:13:12PM -0800, Christoph Lameter wrote:
> On Tue, 5 Feb 2008, Greg KH wrote:
> 
> > > > commit 96990a4ae979df9e235d01097d6175759331e88c
> > > > Author: Christoph Lameter <clameter@sgi.com>
> > > > Date:   Mon Jan 14 00:55:14 2008 -0800
> > > > 
> > > >     quicklists: Only consider memory that can be used with GFP_KERNEL
> > > >     
> > > >     Quicklists calculates the size of the quicklists based on the number of
> > > >     free pages.  This must be the number of free pages that can be allocated
> > > >     with GFP_KERNEL.  node_page_state() includes the pages in ZONE_HIGHMEM and
> > > >     ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
> > > >     
> > > >     Signed-off-by: Christoph Lameter <clameter@sgi.com>
> > > >     Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> > > >     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > >     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > > 
> > > > diff --git a/mm/quicklist.c b/mm/quicklist.c
> > > > index ae8189c..3f703f7 100644
> > > > --- a/mm/quicklist.c
> > > > +++ b/mm/quicklist.c
> > > > @@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quicklist)[CONFIG_NR_QUICK];
> > > >  static unsigned long max_pages(unsigned long min_pages)
> > > >  {
> > > >  	unsigned long node_free_pages, max;
> > > > +	struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
> > > > +
> > > > +	node_free_pages =
> > > > +#ifdef CONFIG_ZONE_DMA
> > > > +		zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) +
> > > > +#endif
> > > > +#ifdef CONFIG_ZONE_DMA32
> > > > +		zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) +
> > > > +#endif
> > > > +		zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES);
> > > > 
> > > > -	node_free_pages = node_page_state(numa_node_id(),
> > > > -			NR_FREE_PAGES);
> > > >  	max = node_free_pages / FRACTION_OF_NODE_MEM;
> > > >  	return max(max, min_pages);
> > > >  }
> > > > 
> > > > 
> > > > I note that this didn't have the stable@kernel.org cc.  Christoph, did we
> > > > deliberately decide not to backport?
> > > > 
> > > 
> > > According to
> > > http://archive.netbsd.se/?ml=linux-stable-commits&a=2008-01&m=6134301 ,
> > > its been added to the stable tree. I remember asking Greg to add it.
> > 
> > And then Christoph told me to remove it...
> 
> No I asked you to add this patch and remove the earlier patch that 
> tinkered around with tlb flushing.

Argh, I'm too confused...

As long as everyone is happy with what is currently queued up for
.22-stable and .23-stable, I'll just shut up now and get on releasing
them :)

thanks,

greg k-h

  reply	other threads:[~2008-02-05 22:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 12:53 Claude Frantz
2008-01-31 14:36 ` Peter Zijlstra
2008-01-31 14:41   ` Claude Frantz
2008-01-31 18:14     ` Peter Zijlstra
2008-02-05 10:07 ` Andrew Morton
2008-02-05 11:03   ` Dhaval Giani
2008-02-05 22:04     ` [stable] " Greg KH
2008-02-05 22:13       ` Christoph Lameter
2008-02-05 22:37         ` Greg KH [this message]
2008-02-05 22:18       ` Oliver Pinter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080205223736.GA7404@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=r31dmaeu@pc0312b.rz.unibw-muenchen.de \
    --cc=stable@kernel.org \
    --subject='Re: [stable] OOM-killer invoked but why ?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).