LKML Archive on
help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: more iommu sg merging fallout
Date: Wed, 06 Feb 2008 15:18:55 -0800 (PST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: FUJITA Tomonori <>
Date: Thu, 07 Feb 2008 08:12:36 +0900

> Really sorry about it.

I am happy to test patches you send to me in the future :-)

> PARISC, Alpha, and IA64 IOMMUs use the two-pass algorithm like SPARC
> but their first pass decides how to merge sg entires (and stores that
> information in the sg entries), then the second pass simpliy follows
> it (Hopefully I understand these IOMMUs correctly, or else I break
> them too).

For now I've removed all of the merging code from the sparc64 IOMMU
support so that other users do not get corrupt filesystems.  It
basically mimicks how the intel-iommu code works, ie. no attempts to
merge anything.

I intend to put merging back in, perhaps something similar to
powerpc's merging logic but without the expensive (in my opinion)
IOMMU allocation every loop.  I think it is better to determine the
segment breaks in one pass, allocate that many IOMMU entries in one
allocation, then fill them all in.

Ideally, we should have some generic code that does all of this.
Then you would only need to test one implementation.

It is definitely doable and increasingly necessary as we have so
many reimplementations of what is essentially identical core code.

  reply	other threads:[~2008-02-06 23:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  4:41 David Miller
2008-02-06 23:12 ` FUJITA Tomonori
2008-02-06 23:18   ` David Miller [this message]
2008-02-06 23:53     ` FUJITA Tomonori
2008-02-07  0:01       ` David Miller
2008-02-07  1:38         ` FUJITA Tomonori
2008-02-12  5:40           ` David Miller
2008-02-16  6:03             ` FUJITA Tomonori
2008-02-18  7:41               ` David Miller
2008-02-19 10:57                 ` FUJITA Tomonori
2008-02-21  6:56                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: more iommu sg merging fallout' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).